raidboss: fix Meso Terminal cleanse doom trigger#996
Open
jacob-keller wants to merge 2 commits intoOverlayPlugin:mainfrom
Open
raidboss: fix Meso Terminal cleanse doom trigger#996jacob-keller wants to merge 2 commits intoOverlayPlugin:mainfrom
jacob-keller wants to merge 2 commits intoOverlayPlugin:mainfrom
Conversation
The cleanse doom trigger for the Meso Terminal dungeon uses the 11F2 effect ID. This appears to no longer be the ID used for the dungeon (as of Patch 7.4), as it now comes in the log as 1441. Based on log data from FFLogs, it appears that the ID changed in Patch 7.4 Update the effectId for Death Penalty to support the new ID. To avoid issues with parsing legacy log files (for example, in the simulator), keep the old ID as well. Fixes OverlayPlugin#995
github-actions
bot
added
raidboss
Author
|
I ran into this earlier today, and I am fairly confident in my checking against FF logs that this change happened as part of Patch 7.4.. I'm not sure if there is a better way to handle this (or how much precedent changed ability IDs really are?) I was quite surprised when I didn't get an alert for the doom debuff. |
Author
|
1441 is listed as one (of the many) IDs for doom in the resources/effect_id.ts file, so I guess the game decided to switch which doom was applied for some reason on the backend? |
valarnin
reviewed
Feb 6, 2026
Comment on lines
+254
to
+255
| // The effect ID changed in Patch 7.4 from 11F2 to 1441. The old ID is | ||
| // kept to allow older logs to continue working in the simulator. |
Collaborator
There was a problem hiding this comment.
The older ID also needs to be kept for other regions that aren't on 7.4 yet, so the wording here should probably be updated.
Suggested change
| // The effect ID changed in Patch 7.4 from 11F2 to 1441. The old ID is | |
| // kept to allow older logs to continue working in the simulator. | |
| // The effect ID changed in Patch 7.4 from 11F2 to 1441. The old ID is | |
| // kept for backwards compatibility with older logs and other regions. |
Collaborator
|
Can confirm that I see |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cleanse doom trigger for the Meso Terminal dungeon uses the 11F2
effect ID. This appears to no longer be the ID used for the dungeon (as
of Patch 7.4), as it now comes in the log as 1441. Based on log data
from FFLogs, it appears that the ID changed in Patch 7.4
Update the effectId for Death Penalty to support the new ID. To avoid
issues with parsing legacy log files (for example, in the simulator),
keep the old ID as well.
Fixes #995