Skip to content

Find WeakResourceLinks and add a right-click menu for them#29

Open
factubsio wants to merge 3 commits intoOwlcatOpenSource:masterfrom
factubsio:master
Open

Find WeakResourceLinks and add a right-click menu for them#29
factubsio wants to merge 3 commits intoOwlcatOpenSource:masterfrom
factubsio:master

Conversation

@factubsio
Copy link
Copy Markdown

Also show an error dialog on the right click commands if the blueprint/asset can't be found

@factubsio
Copy link
Copy Markdown
Author

For issue #27

@factubsio factubsio changed the title Find WeakAssetLinks and add a right-click menu for them Find WeakResourceLinks and add a right-click menu for them Dec 21, 2021
@BurlyWurly
Copy link
Copy Markdown

The new functionality on right click appears to be added (I'm assuming it's the 'copy AssetID') but assets still aren't being imported.

@factubsio
Copy link
Copy Markdown
Author

Can I see your jbp/patch file please?

@BurlyWurly
Copy link
Copy Markdown

I made sure to keep it as foolproof as possible on the patch end for the test run. It's just a basic patch of Irabeth's portrait.

{
    "Data": {
      "m_PortraitImage": {
        "AssetId": "744eda9e1fc78e34c8cecbfb7ffdf6d8"
      },
      "m_HalfLengthImage": {
        "AssetId": "fa1074ebd3eacdd43ad639c9bff175a3"
      },
      "m_FullLengthImage": {
        "AssetId": "285f2ea43cc32a64492251e4caa1b5a8"
      }
    }
}

Patch works and is trying to apply - it breaks her portrait. There's simply a white space because presumably the patched AssetIds point to an asset that isn't being imported.

@factubsio
Copy link
Copy Markdown
Author

Sorry can you show me a screenshot of your Content folder (where the sprites are)?

@BurlyWurly
Copy link
Copy Markdown

Screenshot (167)
Small portrait selected in this.

@factubsio
Copy link
Copy Markdown
Author

Thanks will try to repro locally

@factubsio
Copy link
Copy Markdown
Author

@BurlyWurly this should work now.

Note: you need at least one script + asmdef, (the script can be empty), otherwise the mod will partially fail when loading and not correctly register its own bundles.

@BurlyWurly
Copy link
Copy Markdown

That seems to have done it, great work and thank you! They should probably amend the initial template setup to include setting up a placeholder script, as right now it just has you put in an asmdef.

@factubsio
Copy link
Copy Markdown
Author

@hmmvot any chance of taking a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants