Repository navigation
Method handling #2
Description
Thanks for this nifty little library.
I am testing out the server and I noticed that the methods advertised in the response do not match the route definition, e.g.
local mote = require "mote"
mote.get("/heartbeat", function(ctx)
ctx.response.status = 200
ctx.response.body = { message = "I am alive!" }
end)
local app = mote.create({ port = 5000 })
app:run()Sending a request:
$ curl -iXPUT localhost:5000/heartbeat
HTTP/1.1 404 Not Found
Content-Type: application/json
Keep-Alive: timeout=5, max=1000
Connection: keep-alive
Content-Length: 21
Access-Control-Allow-Origin: *
Access-Control-Allow-Headers: Content-Type, Authorization
Access-Control-Allow-Methods: GET, POST, PUT, PATCH, DELETE, OPTIONS
{"error":"not found"}
In this case I would expect the Access-Control-Allow-Methods to be set to GET (and HEAD if you want to stick with RFC 7231 and the response for PUT should be HTTP 405.
Good to see that HEAD works correctly (at least with curl).
Activity
fix: return 405 Method Not Allowed and scope CORS methods
fix: return 405 Method Not Allowed and scope CORS methods
fix: return 405 Method Not Allowed and scope CORS methods
fix: return 405 Method Not Allowed and scope CORS methods
fix: return 405 Method Not Allowed and scope CORS methods
fix: return 405 for wrong method, scope CORS allowed methods (#3)
pgagnidze commentedon Mar 22, 2026
Thanks for reporting this, @scossu! Both issues are fixed in #3:
PUT /heartbeatnow returns405 Method Not AllowedwithAllow: GET, OPTIONSOPTIONS /heartbeatpreflight now returnsAccess-Control-Allow-Methods: GET, OPTIONS(scoped to the path, not global)The fix will be available on LuaRocks once
v0.1.7is tagged.scossu commentedon Mar 22, 2026
Thanks for the quick fix @pgagnidze .