mp4: header creation/modification timestamps, read and write - #8
Open
jayhf wants to merge 1 commit into
Open
Conversation
jayhf
marked this pull request as ready for review
August 14, 2026 20:55
Author
|
@MagicalTux can you please review this? |
jayhf
force-pushed
the
jf/header-timestamps
branch
from
August 25, 2026 19:05
7714ffd to
1013ace
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds read and write support for the ISO/IEC 14496-12 header timestamps (mvhd §8.2.2, tkhd §8.3.2, mdhd §8.4.2), which the muxer previously hardcoded to zero and the demuxer skipped past. All values are in the header epoch, seconds since 1904-01-01 UTC, on both sides — no conversion on intake, so a value read off a file feeds straight back into the muxer.
15 integration tests, including a byte-patched fixture putting six distinct values in the six fields, and a PATH-gated cross-check that reads back a stamp written by ffmpeg. Note the ffmpeg check skips on CI, since the crate-ci shim installs no extra packages.