Skip to content

Potential fixes for 2 code quality findings #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
TKorr wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Potential fixes for 2 code quality findings #35

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6216bf8
Apply suggested fix to src/store/weight.rs from Copilot Autofix
TKorr Feb 24, 2026
047bb88
Apply suggested fix to src/store/weight.rs from Copilot Autofix
TKorr Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/store/weight.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,7 +501,16 @@
pub fn try_insert(&mut self, key: K, value: Arc<V>) -> Result<Option<Arc<V>>, StoreFull> {
let new_weight = self.compute_weight(value.as_ref());
if let Some(entry) = self.map.get_mut(&key) {
let next_total = self.total_weight - entry.weight + new_weight;
debug_assert!(
self.total_weight >= entry.weight,
"WeightStore invariant violated: total_weight ({}) is less than entry.weight ({})",
self.total_weight,
entry.weight
);
let next_total = self
.total_weight
.saturating_sub(entry.weight)
.saturating_add(new_weight);
if next_total > self.capacity_weight {
return Err(StoreFull);
}
Expand Down Expand Up @@ -548,9 +557,10 @@
/// assert_eq!(store.total_weight(), 5);
/// store.remove(&"key");
/// assert_eq!(store.total_weight(), 0);
/// ```

Check warning on line 560 in src/store/weight.rs

View workflow job for this annotation

GitHub Actions / cargo fmt 

Diff in /home/runner/work/cachekit/cachekit/src/store/weight.rs
pub fn remove(&mut self, key: &K) -> Option<Arc<V>> {
let entry = self.map.remove(key)?;
debug_assert!(self.total_weight >= entry.weight, "total_weight underflow in remove");
self.total_weight = self.total_weight.saturating_sub(entry.weight);
self.metrics.inc_remove();
Some(entry.value)
Expand Down
Loading