Skip to content

fix: avoid unused path warning on non-Unix - #61

Closed
P4suta wants to merge 1 commit into
mainfrom
fix/windows-sync-parent-warning
Closed

P4suta wants to merge 1 commit into
mainfrom
fix/windows-sync-parent-warning

Conversation

@P4suta

@P4suta P4suta commented Sep 19, 2026

Copy link
Copy Markdown
Owner

Split sync_parent into Unix and non-Unix implementations so Windows builds do not report an unused path parameter. Validation: cargo fmt passed; workspace Clippy with warnings denied passed; atomic tests passed; OComment dogfood reported zero findings. The full Windows workspace test run still has the pre-existing output::tests::a_first_segment_that_reads_as_a_drive_letter_is_disambiguated failure.

@coderabbitai

coderabbitai Bot commented Sep 19, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 60e99994-c862-430f-8a20-a9e2f3df415b


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@P4suta

P4suta commented Sep 19, 2026

Copy link
Copy Markdown
Owner Author

Taken into #63, which also runs the suite on Windows and macOS — the reason nobody had seen the warning, or the drive-letter test failure beside it, is that cargo test only ever ran on Linux while release.yml shipped a Windows binary.

@P4suta P4suta closed this Sep 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant