Skip to content

feat(framelib): add online v2 frame definitions and frame generation#50

Merged
KafCoppelia merged 1 commit intodevfrom
v2_online
Apr 22, 2026
Merged

feat(framelib): add online v2 frame definitions and frame generation#50
KafCoppelia merged 1 commit intodevfrom
v2_online

Conversation

@AEGO-WRJ
Copy link
Copy Markdown

Summary

This PR adds online-core v2 support in framelib, including frame definitions, frame generation, and corresponding tests.

Changes

  • add online v2 frame definitions in paicorelib/framelib/frame_defs.py
  • add online v2 frame generation in paicorelib/framelib/frame_gen_v2.py
  • add online v2 test coverage in tests/framelib/test_frame_gen_v2.py
  • keep existing legacy/offline code paths unchanged
  • keep tests/framelib/test_base.py unchanged

Notes

  • implementation follows the existing v2/offline style as closely as possible
  • endian handling and bit-field packing were aligned with the online v2 frame definitions
  • only incremental updates were made for v2 support; old version behavior was not modified

Validation

  • online v2 tests in tests/framelib/test_frame_gen_v2.py passed

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

❌ Patch coverage is 95.43039% with 43 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
paicorelib/framelib/frame_gen_v2.py 84.69% 26 Missing and 17 partials ⚠️
Files with missing lines Coverage Δ
paicorelib/__init__.py 91.30% <100.00%> (ø)
paicorelib/core_defs_v2.py 100.00% <100.00%> (ø)
paicorelib/core_model_v2.py 100.00% <100.00%> (ø)
paicorelib/framelib/frame_defs.py 100.00% <100.00%> (ø)
paicorelib/neuron_defs_v2.py 100.00% <100.00%> (ø)
paicorelib/neuron_model_v2.py 100.00% <100.00%> (ø)
tests/framelib/test_frame_gen_v2.py 100.00% <100.00%> (ø)
paicorelib/framelib/frame_gen_v2.py 91.16% <84.69%> (-6.97%) ⬇️

Comment thread paicorelib/framelib/frame_defs.py
Comment thread paicorelib/framelib/frame_defs.py Outdated
Comment thread paicorelib/framelib/frame_gen_v2.py Outdated
Comment thread paicorelib/framelib/frame_gen_v2.py Outdated
Comment thread paicorelib/framelib/frame_gen_v2.py
Comment thread paicorelib/framelib/frame_gen_v2.py Outdated
Comment thread paicorelib/framelib/frame_gen_v2.py
@AEGO-WRJ AEGO-WRJ force-pushed the v2_online branch 3 times, most recently from 48ceea3 to cc11dbf Compare April 22, 2026 06:17
@KafCoppelia KafCoppelia merged commit 9508e0b into dev Apr 22, 2026
12 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants