Update build.rs

[voidbar]

Please don't merge until this is tested

[pbl007]

Hi. Compiled successfully(!) with a few warnings:

⚠️ Warning: You specified maturin >=1.6, <1.7 in pyproject.toml under build-system.requires, but the current maturin version is 1.7.0

warning: the following packages contain code that will be rejected by a future version of Rust: nalgebra v0.26.2

⚠️ Warning: Couldn't find the symbol PyInit_librpysight in the native library. Python will fail to import this module. If you're using pyo3, check that #[pymodule] uses librpysight as module name

Should I merge?

Thanks again!

[voidbar]

I've fixed the first warning.
If you manage to build and run the project correctly, you can go ahead and merge this

[pbl007]

cargo run cli --release returns
Finished dev profile [unoptimized + debuginfo] target(s) in 52.36s
warning: the following packages contain code that will be rejected by a future version of Rust: nalgebra v0.26.2
note: to see what the problems were, use the option --future-incompat-report, or run cargo report future-incompatibilities --id 1
Running target\debug\cli.exe cli --release
error: process didn't exit successfully: target\debug\cli.exe cli --release (exit code: 0xc0000135, STATUS_DLL_NOT_FOUND)

When calling the executable (.\target\release\cli.exe) does nothing instead of creating the log file and popping up 4 windows.

I tried adding a simple println!("starting rpysight"); and rebuilding but got the same behavior.

[voidbar]

This issue is that I don't have a windows machine to test this on. Do you know if this expected to work on Mac?
Anyway, i'll try to get to it tonight

[pbl007]

Hardware is supported on Win and Linux but code should at least gracefully fail if the TimeTagger (aka the hardware) is not find. If you’d like (and huge thanks again!) I can also set you up with remote access to the workstation hooked to the hardware (AnyDesk, details over private chat). ------------------------------------------------------------------------------------- Prof. Pablo Blinder, PhD https://pblab.tau.ac.il/ Neurobiology, Biochemistry and Biophysics School, George S. Wise Faculty of Life Sciences, and Sagol School for Neuroscience, Tel Aviv University ------------------------------------------------------------------------------------- On Jul 9, 2024, at 09:19, Tomer Lev ***@***.***> wrote: This issue is that I don't have a windows machine to test this on. Do you know if this expected to work on Mac? Anyway, i'll try to get to it tonight — Reply to this email directly, view it on GitHub<#10 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AALGGKKTKJ554QQ7PXF3673ZLN6FJAVCNFSM6AAAAABKPEZRHOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJWGY3TOMJZHA>. You are receiving this because you commented.Message ID: ***@***.***>

[voidbar]

What happens when you run target\debug\cli.exe through the terminal?
Also, there should be a log file in target/rpysight.log, could you see if there anything there?

[pbl007]

Same behavior. Log file is no longer being created. ------------------------------------------------------------------------------------- Prof. Pablo Blinder, PhD https://pblab.tau.ac.il/ Neurobiology, Biochemistry and Biophysics School, George S. Wise Faculty of Life Sciences, and Sagol School for Neuroscience, Tel Aviv University ------------------------------------------------------------------------------------- On Jul 9, 2024, at 23:27, Tomer Lev ***@***.***> wrote: What happens when you run target\debug\cli.exe through the terminal? Also, there should be a log file in target/rpysight.log, could you see if there anything there? — Reply to this email directly, view it on GitHub<#10 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AALGGKJXZYXCY3ZGUXNQNSTZLRBR7AVCNFSM6AAAAABKPEZRHOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJYGY3TANJYGA>. You are receiving this because you commented.Message ID: ***@***.***>