docs(monitoring): say in both configs why an edit needs a deploy - #424
Merged
Conversation
Loki reads its config once at startup and has no reload endpoint, and Python reads main.py once when the process starts. Both are single-file bind mounts, so a git pull swaps the inode under a running container and a plain `docker compose up -d` applies nothing. Since #422 the DEP-6 hash label does apply an edit, and these headers say so where somebody is standing when they edit the file rather than only in the compose labels. Both files fail quietly if an edit never loads. loki-config.yml holds the retention settings, so a change that did not take either deletes logs you believed you were keeping or fills the disk. main.py carries the exporter's own scrape-health metrics, so stale code keeps reporting healthy while serving the old numbers. This is also the content-only change that proves the fingerprint path: the previous deploy recreated both services because the label block itself was new, which proves nothing about the digest. The next deploy changes bytes only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEP-6 task D6-4, the PR B half of the split that #419/#420 used for
config.alloy.What this changes
A header comment at the top of
monitoring/loki/loki-config.ymland in the existing header block ofmonitoring/tautulli-exporter/main.py. Comments only, no code, no config values, no compose changes.Why
Both files are read once at process start and are single-file bind mounts, so a
git pullreplaces them by rename and the running container keeps reading the old inode. A plaindocker compose up -dapplies nothing. Since #422 the DEP-6homelab.config-shalabel does apply an edit, but that fact only lived in the compose labels, which is not where somebody is standing when they edit the file.Both fail quietly if an edit never loads:
loki-config.ymlholdsretention_periodandreject_old_samples_max_age. A retention edit that silently never loaded either deletes logs you believed you were keeping or fills the disk, and both look like a healthy system until the damage is done.main.pydefines two of the exporter's own scrape-health metrics, so old code keeps reporting healthy while serving the old numbers.It is also the proof
The deploy after #422 recreated both services because the
labels:block was itself a service-definition change, so it proved nothing about the digest path. This PR changes bytes only. The deploy after it is the one that tests the fingerprint:Createdshould move andhomelab.config-shashould change with nothing else different.Checks
bash tests/run.sh: every suitefailed=0pre-commit run --all-files: all hooks passloki -verify-configin a throwawaygrafana/loki:3.7.6container (no CI gate parses this file):config is validpython3 -m py_compile monitoring/tautulli-exporter/main.py: clean