feat(crash-report): 支持收起错误报告并在独立窗口中查看 - #3614
Open
whitecat346 wants to merge 2 commits into
Open
whitecat346 wants to merge 2 commits into
whitecat346 wants to merge 2 commits into
Conversation
pcl-ce-automation
Bot
added
🛠️ 等待审查
Contributor
审查者指南该 PR 通过扩展通用消息框的第四按钮能力，并重构崩溃报告展示为基于快照和会话的流程，实现报告弹窗可收起、在独立窗口中恢复查看，同时增加配置开关、设置页联动和多语言支持。 崩溃报告停靠与重新打开的时序图sequenceDiagram
participant CrashAnalysis as CrashAnalysis
participant Presenter as CrashDialogPresenter
participant Dialog as MsgBoxWrapper
participant Session as CrashReportSession
participant Window as CrashReportWindow
CrashAnalysis->>Presenter: Output(isHandAnalyze, extraFiles)
Presenter->>Session: CloseWindow()
Presenter->>Dialog: ShowWithCustomButtons(report, Button1..Button4)
Dialog-->>Presenter: selectedButton
alt selectedButton is 1
Presenter->>Session: Collapse(report)
else selectedButton is 4
Presenter->>Session: Collapse(report)
Presenter->>Session: OpenWindow()
Session->>Window: Show report snapshot
end
文件级变更
提示与命令与 Sourcery 交互
自定义使用体验访问你的控制面板以：
获取帮助Original review guide in EnglishReviewer's Guide该 PR 通过扩展通用消息框的第四按钮能力，并重构崩溃报告展示为基于快照和会话的流程，实现报告弹窗可收起、在独立窗口中恢复查看，同时增加配置开关、设置页联动和多语言支持。 Sequence diagram for docking and reopening a crash reportsequenceDiagram
participant CrashAnalysis as CrashAnalysis
participant Presenter as CrashDialogPresenter
participant Dialog as MsgBoxWrapper
participant Session as CrashReportSession
participant Window as CrashReportWindow
CrashAnalysis->>Presenter: Output(isHandAnalyze, extraFiles)
Presenter->>Session: CloseWindow()
Presenter->>Dialog: ShowWithCustomButtons(report, Button1..Button4)
Dialog-->>Presenter: selectedButton
alt selectedButton is 1
Presenter->>Session: Collapse(report)
else selectedButton is 4
Presenter->>Session: Collapse(report)
Presenter->>Session: OpenWindow()
Session->>Window: Show report snapshot
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
你好——我发现了 1 个问题
面向 AI 代理的提示
请处理本次代码审查中的评论：
## 单独评论
### 评论 1
<location path="Plain Craft Launcher 2/Modules/Minecraft/CrashAnalysis/Presentation/CrashDialogPresenter.cs" line_range="26" />
<code_context>
- var thirdButtonText = isHandAnalyze
- ? ""
- : Lang.Text("Crash.Dialog.Button.ExportReport");
+ var report = new CrashReportSnapshot(context, crashContent, title, isHandAnalyze, extraFiles);
- var secondButtonAction = _GetSecondButtonAction(
</code_context>
<issue_to_address>
**需要处理的问题（bug_risk）：** 该 presenter 实例化了 `CrashReportSnapshot` 并调用了 `CrashReportSession`，但仓库中的任何位置都不存在这两种类型。因此，项目会因无法解析类型名称而编译失败。
**建议修复方案：** 将 `CrashReportSnapshot` 和 `CrashReportSession` 的实现添加到项目中，或者将这些引用替换为现有的报告管理类型。
</issue_to_address>Original comment in English
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="Plain Craft Launcher 2/Modules/Minecraft/CrashAnalysis/Presentation/CrashDialogPresenter.cs" line_range="26" />
<code_context>
- var thirdButtonText = isHandAnalyze
- ? ""
- : Lang.Text("Crash.Dialog.Button.ExportReport");
+ var report = new CrashReportSnapshot(context, crashContent, title, isHandAnalyze, extraFiles);
- var secondButtonAction = _GetSecondButtonAction(
</code_context>
<issue_to_address>
**issue (bug_risk):** The presenter instantiates `CrashReportSnapshot` and calls `CrashReportSession`, but neither type is present anywhere in the repository. The project therefore fails to compile with unresolved type-name errors.
**Suggested fix:** Add the `CrashReportSnapshot` and `CrashReportSession` implementations to the project, or replace these references with existing report-management types.
</issue_to_address>![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bf5555c3a8
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Hill23333
requested changes
Sep 14, 2026
Hill23333
approved these changes
Sep 14, 2026
Hill23333
left a comment
Hill23333
left a comment
Contributor
There was a problem hiding this comment.
代码通过，翻译部分转接 @Chiloven945 审查
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0640330473
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| private void BtnExport_Click(object sender, ModBase.RouteEventArgs e) | ||
| { | ||
| // 打包压缩包可能耗时较久，放到后台线程，避免卡住界面 | ||
| ModBase.RunInThread(() => _report.ExportReport()); |
There was a problem hiding this comment.
If the user clicks Export again after dismissing the first save dialog but before packaging finishes, this starts another background export for the same snapshot. Both calls use the same context.TempFolder/Report workspace in CrashReportExporter, where each invocation deletes and recreates that directory, so the exports can delete files out from under each other and fail or produce incomplete archives. Disable the button while an export is active or otherwise serialize exports for a snapshot.
Useful? React with 👍 / 👎.
Chiloven945
reviewed
Sep 14, 2026
Chiloven945
left a comment
Chiloven945
left a comment
Member
There was a problem hiding this comment.
i18n 没有问题，and 不是 en-US 和 zh-CN 的语言可以不用翻译。这两个是需要严格审查的，其他交由 Weblate 翻译即可。
Chiloven945
requested changes
Sep 14, 2026
Member
There was a problem hiding this comment.
强烈反对以多窗口的形式进行呈现并引入新的控件表达方式。
倾向支持复用媒体控制和任务管理的按钮，点击后重新弹出上一次崩溃信息。原因如下：
- PCL 的整体 UI 语言设计风格就不适合多窗口的表现形式，引入新的表现形式风险开销过大。我们并没有对 Crash Report 本身的内容进行增加，因此复用 MyMsgBox 没有大的问题，引入新的反而一会 MyMsgBox 一会窗口……（除此之外插一嘴，之前尝试重构崩溃分析的时候做过单独页面的崩溃报告……）
- 完全可以复用已有的任务管理和媒体播放的按钮，现在引入的新控件设计和 Toast 雷同，但两种有不同功能，容易混淆。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3612
Sourcery 摘要
为错误报告增加可配置的收起入口和独立窗口查看体验。
新功能：
改进：
Original summary in English
Summary by Sourcery
为错误报告增加可配置的收起入口和独立窗口查看体验。
New Features:
Enhancements: