Fix Prior.from_par_dict for missing priorParameters columns#341
Merged
dweindl merged 1 commit intoPEtab-dev:developfrom Dec 12, 2024
Merged
Fix Prior.from_par_dict for missing priorParameters columns#341dweindl merged 1 commit intoPEtab-dev:developfrom
dweindl merged 1 commit intoPEtab-dev:developfrom
Conversation
Previously, missing `*PriorParameters` would have resulted in a KeyError.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #341 +/- ##
========================================
Coverage 74.58% 74.59%
========================================
Files 56 56
Lines 5517 5518 +1
Branches 958 958
========================================
+ Hits 4115 4116 +1
Misses 1036 1036
Partials 366 366 ☔ View full report in Codecov by Sentry. |
dweindl
added a commit
to dweindl/libpetab-python
that referenced
this pull request
Dec 12, 2024
…v#341) Previously, missing `*PriorParameters` would have resulted in a KeyError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, missing
*PriorParameterswould have resulted in a KeyError.