[1.12] Performance improvements, bug fixes and clean up

[Meldexun]

This PR is a collection of a lot of performance improvements, bug fixes and a bit of code clean up. Due to the huge amount of changes I recommend checking every commit individually. This should be doable because every commit only changes a single thing and the individual changes are (currently) not split among multiple commits.

Currently all changes are untested. I will try to do some testing in the next days and report back.

Here is a list of the reasoning behind each commit:

• Improve LocalWorld#isStructureInRadius implementations
  Performance: Iterate whole area directly instead of going in circles (usually done to find the nearest structure but that isn't needed here)
  Bug Fix: MapGenStructure#canSpawnStructureAtCoords may crash due to MapGenBase#world being null
  Clean up

• Improve EntityNames#toInternalName
  Performance: Very slow, iterates map + a lot of regex. Not exactly the same functionality as before. Previously it removed all occurances of "minecraft:", "entity" and "_". This means something like z_ominecraft:mbentityi_e__ would be a valid alias for zombie. Now only the "minecraft:" prefix is removed and the aliases specified by EntityNames are supported.

• Fix captureBlockSnapshots corruption when setBlockState errors
  Bug Fix: When Chunk#setBlockState throws an exception the captureBlockStates field might get corrupted which creates a massive memory leak

• Clean up BlockPos2D
  Clean up

• Fix missing BlockPos2D#hashCode implementation
  Bug Fix: This class is used as a HashMap key in OTGChunkGenerator but is missing a hashCode implementation

• Clean up BlockPos3D
  Clean up

• Fix BlockPos3D#equals
  Bug Fix: y coordinate is not compared

• Fix missing BlockPos3D#hashCode implementation
  Bug Fix: Didn't find any hash map usage but doesn't hurt to implement this as well

• Replace FifoMap with LRUCache
  Performance: Use access order instead of write order to determine which entry to remove (LRU instead of FIFO). Also, initialize map with sufficient size so that no resizing is ever needed,

• Improve DimensionConfigBase constructor
  Performance: Avoid creating ArrayList just to call toArray in the end

• Improve DefaultMaterial lookups
  Performance: Use HashMap instead of TreeMap for lookupName
  Clean up

• Improve PlantType lookup
  Performance: Use HashMap instead of TreeMap for LOOKUP_MAP

• Improve ChunkGenerator#getChunk
  Performance: Caching like this only hurts performance. Calling getLoadedChunk is unnecessary if just calling getChunk when the result is null.

• Clean up BiomeGroup
  Clean up

• Fix unnecessary ArrayList creation
  Performance: Iterate list directly instead of creating ArrayList from sub list

• Improve BiomeGroup depth map cache
  Performance: BiomeGroupManager#isBiomeDepthMapEmpty only checks if any depth map is non-empty but this can be done without creating a depth map.

• Remove unnecessary initGroupSeed call
  Clean up: LayerLandRandom doesn't call nextGroupInt which makes this useless

• Rename getRandomOf4 to mostCommonOrRandom
  Clean up: Confusing name

• Improve mostCommonOrRandom
  Performance: Less comparisons

• Add InvalidConfigException constructor with cause argumnet
  Feature: Adds option to create InvalidConfigException with a cause. Stacktrace won't be truncated when throwing a InvalidConfigException using the new constructor this way.

• Clean up StringHelper
  Performance: Avoid Collection#toArray in join. Use InvalidConfigException constructor with cause.
  Clean up

• Improve StringHelper.readCommaSeperatedString
  Performance: Use ArrayList instead of LinkedList. Return List instead of calling List#toArray at the end.
  Clean up

• Clean up Resource.hashCode
  Clean up

• Improve FileSettingsReaderOTGPlus.readSettings
  Performance: Only use up to 3 calls to indexOf or lastIndexOf per line.
  Clean up

• Improve NBT reading
  Performance: Use BufferedInputStream

• Fix silver shulker box id
  Bug Fix: Wrong id (228 is cyan shulker box)

• Add glazed terracotta
  Bug Fix: Add missing glazed terracotta entries

• Remove "UNKNOWN_BLOCK"
  Bug Fix: IDs not used by vanilla will used by mods

• Add fastutil dependency
  Feature: Make FastUtil 7.1.0 available in common package as it is used by Minecraft already

• Improve layer random number generator
  Implement custom RNG (similar to java.util.SplittableRandom) to generate good random numbers. LayerRNG serves as an abstraction layer to support legacy RNG implementation for old worlds. Store WorldSaveData in ServerConfigProvider to be able to determine the OTG which was used to create a world.
  ~~NOTE: Currently the new RNG is unused because it expects the world creation version to be >=9 but I didn't change the world creation version yet (see here)~~Fixed

• Create WeightedList to replace TreeMap iteration
  Performance: Implement WeightedList to avoid TreeMap iteration. WeightedList#getRandom returns a random element based on the weight by traversing a AVL tree.

• Format LocalMaterialData
  Clean up

• Format ReplacedBlocksMatrix
  Clean up

• Reimplement LocalMaterialData
  Reimplementation of LocalMaterialData and its subclasses for various performance improvements and bug fixes. The most important changes are:
  Use enum + Reference2IntMap to greatly speed up MaterialSet#contains
  Make LocalMaterialData immutable
  Replace LocalMaterialData#canSnowFallOn with LocalWorld#canPlaceSnowAt to allow correct checking if snow is placeable
  Avoid all DefaultMaterial methods because most are just approximations and don't work for modded blocks anyway

[Meldexun]

Alright this is it. Currently doing the final testing round. Below I will explain the new commits.

• Fix IndexOutOfBoundsException
  Fix: Issue introduced in 8552b28

• Fix reading last element of string list
  Fix: Issue introduced in b271c65

• Remove unused import
  Cleanup

• Remove unused DefaultMaterial#isSolid
  Cleanup

• Fix missing fastutil on bukkit
  Fix: Common project already has fastutil dependency. So, not sure why this is needed but otherwise building the bukkit subproject fails.

• Increment world save version
  Feature: Enables eb4add9

• Fix parseForWorld returning null
  Fix: Issue introduced in Reimplement LocalMaterialData

• Fix NoSuchElementException
  Fix: Issue introduced in Create WeightedList to replace TreeMap iteration

• Fix OTGChunkGenerator#getBlockColumnInUnloadedChunk returning empty a…
  Fix: OTGChunkGenerator#getBlockColumnInUnloadedChunk returns null instead of air

• Fix missing null or empty check
  Fix: Issue introduced in Reimplement LocalMaterialData

• Fix check if material is in material set
  Fix: Issue introduced in Reimplement LocalMaterialData

• Add commons-lang dependency
  Feature: Make commons-lang dependency which is part of vanilla MC available in common subproject.

• Fix not finding blocks by OTG name
  Fix: Issue introduced in Improve DefaultMaterial lookups

• Fix not finding entities by OTG alias
  Fix: Issue introduced in Improve EntityNames#toInternalName

• Clean up CustomStructure
  Cleanup

• Fix CustomStructure#hashCode ignoring x, y, z
  Fix: Old implementation xor's each coordinate with itself which always returns 0

• Fix CustomStructureCoordinate#hashCode ignoring parts of x, y
  Fix: Lowest 13 bits of x and lowest 7 bits of y were ignored. Also x, y, and z are likely very small and thus similar which makes using xor's produce a bad hash.

• Fix comments
  Cleanup: Comments were referencing the wrong class.

• Remove unused import
  Cleanup

• Delete unused class BlockHelper
  Cleanup

• Clean up MaterialSet
  Cleanup

• Add floorDiv and floorMod methods
  Feature: Add math utility methods

• Improve ChunkCoordinate math
  Performance: Use bitshift + or and custom floorDiv and floorMod implementations.

• Improve CustomStructureCoordinate
  Performance: Use bitshift

• Add cache for MaterialSet instances
  Performance: In Dregora there are a lot of material sets with the same content. Cache material sets to reduce RAM usage.

• Remove setting captureBlockStates to true
  Performance: Was causing massive lag in RLCraft Dregora when cascading chunk gen happens.

• Add methods to create (de-)compression streams
  Feature: Add IO utility methods

• Improve string reading/writing
  Cleanup: Make string reading/writing more robust and improve readability.

• Improve LayerFromImage memory requirement
  Performance: Lazily load parts of image when needed instead of always having the complete image in memory.

• Improve NBT tag IO
  Performance, Cleanup: Detect if compression is used instead of trying and potentially failing. Reimplementation to cleanup code and improve readability. Add support for long array tags.

• Improve BO4 reading/writing
  Performance: Use buffered, compression/decompression streams instead of reading to byte array, then decompressing to new byte array and then reading from byte array (same for writing).

• Improve CustomStructureFileManager
  Performance: Use buffered, compression/decompression streams instead of reading to byte array, then decompressing to new byte array and then reading from byte array (same for writing).
  Also, fix lag caused by CustomStructureFileManager#mergeRegionData in pregenerated worlds.
  Cleanup: Use utility methods to massively reduce duplicate code.

• Remove unused (de-)compress methods
  Cleanup

• Remove unused readStringFromBuffer method
  Cleanup

• Move coords into a single int in CustomObjectConfigFunction
  Performance: Reduce memory footprint of CustomObjectConfigFunction instances

• Remove holder field
  Performance: Remove barely used field to reduce memory footprint.

• Remove error info fields
  Performance: Only used by CustomObjectErroredFunction. Move to reduce memory footprint.

• Create TagProvider.java
  Feature: Class for future improvements

• Create TagContainer.java
  Feature: Class for future improvements

• Create BlockContainer.java
  Feature: Class for future improvements

• Replace material, nbt, nbtPath fields with BlockContainer field
  Performance: Reduce memory footprint by combining material, nbt, and nbtPath fields.

• Cache BlockFunctions of BO3s and BO4s
  Performance: Recreating these objects every time is slow. Also, with the reduced memory footprint of BlockFunction instances the memory usage now is not a lot higher compared to storing the raw data in arrays.

• Clean up rotation code
  Cleanup

• Avoid potential NPEs
  Fix: Make sure that current block of random functions is never null.

• Fix BO4 trying to place null
  Fix: When generating random blocks in a BO4 it can happen that no block succeeds the chance check.

• Fix material comparisons
  Fix: Issue introduced by Reimplement LocalMaterialData

• Fix ReplacedBlocksMatrix#replaceBlock using wrong keys
  Fix: Issue introduced by Reimplement LocalMaterialData

• Fix BlockContainer#of using wrong key
  Fix: Issue introduced by Replace material, nbt, nbtPath fields with BlockContainer field

• Improve BO3 generation
  Performance: Use LongOpenHashSet instead of HashSet<ChunkCoordinate>. Lazily rotate block functions.
  Cleanup

• Fix deadlock when calling CustomStructureCache#saveToDisk
  Fix: Old code is very brittle and sometimes caused deadlocks in RLCraft Dregora.

• Fix bias when calculating randomized spawnpoint
  Fix: Old code did not generate points in circle uniformly.

• Avoid IndexOutOfBoundsException
  Fix: RLCraft Dregora crashed here. Add bounds checks to avoid crash. (TODO find and fix actual issue leading to this)

• Fix NullPointerException
  Fix: BukkitWorld#getMaterial/ForgeWorld#getMaterial could return null instead of air.
  Performance: Use getLoadedChunkAt instead of isLoaded + getChunk. Avoid creating BlockPoss in getBlockColumnInUnloadedChunk. Iterate sections directly instead in getBlockColumnInUnloadedChunk.
  Cleanup

• Improve LayerBiomeBorder#getInts
  Performance: Cache a lot of array calls and calculations and check early if improvedBiomeBorders is enabled.

• Improve random block function reading
  Performance: Throwing a lot of exception is slow. Check if string is a number with custom method instead of Integer.parseInt + catch block.

• Cache common material relations
  Performance: Improvement to Reimplement LocalMaterialData

• Cache air material
  Performance: Improvement to Reimplement LocalMaterialData

• Cleanup method return types
  Cleanup

• Fix out of bounds coordinates
  Fix: Issue introduced in Move coords into a single int in CustomObjectConfigFunction

[authvin]

I haven't combed through every change in detail, but everything looks good to me. There's quite a few things I might want to port forward to the 1.20 version, when I have time. Leaving it as approved now, in case there's anything else that needs adding, but I'm fine with making a new release with these changes - assuming they've been tested, like you mentioned

[Meldexun]

Eagle found some rotation issues that need fixing and I also have a few small performance tweaks to finish up. But no big changes are planned now.
Will report back once everything is finished.