Add .GetOrder() and .GetOperation() to IProcessExtensions#113
Merged
1nf0rmagician merged 1 commit intoOct 13, 2025
Merged
Conversation
seveneleven
reviewed
Jul 30, 2025
seveneleven
left a comment
seveneleven
left a comment
Contributor
There was a problem hiding this comment.
Great work. I like the comments!
seveneleven
changed the title
.GetOrder() and .GetOperation() to IProcessExtensions.GetOrder() and .GetOperation() to IProcessExtensions
seveneleven
changed the title
.GetOrder() and .GetOperation() to IProcessExtensions.GetOrder() and .GetOperation() to IProcessExtensions
1nf0rmagician
requested changes
Sep 23, 2025
| var process = new Process { Recipe = recipe}; | ||
|
|
||
| // Act | ||
| var orderNumber = process?.GetOrder(); |
Member
There was a problem hiding this comment.
Even though this is a very simple test, I want to point out: It is generally recommended to only test one unit per unit test, i.e. split this test into to methods 😉
|
|
||
| namespace Moryx.ControlSystem.Tests.Mocks; | ||
|
|
||
| public class DummyRecipe : ProductionRecipe, IOrderBasedRecipe |
Member
There was a problem hiding this comment.
Remember when porting to future: There is already a DummyRecipe in MOryx.ControlSystem.TestTools
…sions` Also added tests. [closes #367]
DosenSuppe
force-pushed
the
feature/iprocessextensions-get-order-and-operation-number
branch
from
528e108 to
d6d936e
Compare
1nf0rmagician
approved these changes
Oct 13, 2025
1nf0rmagician
deleted the
feature/iprocessextensions-get-order-and-operation-number
branch
1nf0rmagician
restored the
feature/iprocessextensions-get-order-and-operation-number
branch
1nf0rmagician
deleted the
feature/iprocessextensions-get-order-and-operation-number
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also added a UnitTest
Closes #367