Add automatic support for Inputs to the VisualInstructionParameters#117
Merged
MathoMathiasCamara merged 2 commits intoSep 24, 2025
Merged
Conversation
Added the Inputs property to the VisualInstructionParameters base class and update the `VisualInstrucot.Execute` methods to pass the inputs from the parameters to the ActiveInstruction
1nf0rmagician
left a comment
1nf0rmagician
left a comment
Member
There was a problem hiding this comment.
I would suggest to add an IVisualInstructionParameters interface, marking the IVisualInstructions interface obsolete. The new interface should include the inputs then to remove the casts from the extensions in MORYX 10.
@dbeuchler what's you opinion on this? I was also wondering whether we could get rid of the interface completely, but I'm unsure whether we want to use the VisualInstructionParameters class instead in future 🤔
Member
|
As discussed, we would suggest removing the |
dbeuchler
approved these changes
Sep 24, 2025
MathoMathiasCamara
deleted the
feature/add-inputs-to-visualinstructorparameter
branch
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the Inputs property to the VisualInstructionParameters base class and update the
VisualInstrucot.Executemethods to pass the inputs from the parameters to the ActiveInstruction