Skip to content

Potentially fix sync bug #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Duddino wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Potentially fix sync bug #607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9b0262a
Potentially fix sync bug
Duddino Oct 27, 2025
cab7e3d
prettier
Duddino Nov 10, 2025
2ffb174
Address review
Mar 24, 2026
909e37e
Fix tests
Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion chain_params.prod.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@
"defaultColdStakingAddress": "SdgQDpS8jDRJDX8yK8m9KnTMarsE84zdsy",
"stakeSplitTarget": 50000000000,
"mnReward": 600000000,
"defaultStartingShieldBlock": 4190531
"defaultStartingShieldBlock": 4190531,
"confirmsForSaving": 20
},
"testnet": {
"name": "testnet",
Expand Down
3 changes: 2 additions & 1 deletion chain_params.test.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@
"defaultColdStakingAddress": "SdgQDpS8jDRJDX8yK8m9KnTMarsE84zdsy",
"stakeSplitTarget": 50000000000,
"mnReward": 600000000,
"defaultStartingShieldBlock": 4190531
"defaultStartingShieldBlock": 4190531,
"confirmsForSaving": 20
},
"testnet": {
"name": "testnet",
Expand Down
4 changes: 4 additions & 0 deletions scripts/transaction_builder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,10 @@ export class TransactionBuilder {
}
}

setTime(time) {
this.#transaction.blockTime = Math.floor(time.getTime() / 1000);
}

build() {
const tx = this.#transaction;
if (tx && !tx.vin.length) {
Expand Down
9 changes: 8 additions & 1 deletion scripts/wallet.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1177,6 +1177,7 @@ export class Wallet {
changeAddress = '',
returnAddress = '',
memo = '',
time = new Date(),
} = {}
) {
let balance;
Expand Down Expand Up @@ -1276,6 +1277,7 @@ export class Wallet {
}
}
}
transactionBuilder.setTime(time);
return transactionBuilder.build();
}

Expand Down Expand Up @@ -1410,7 +1412,12 @@ export class Wallet {
await this.#shield?.finalizeTransaction(transaction.txid);
}

if (!skipDatabase) {
if (
!skipDatabase &&
transaction.blockHeight !== -1 &&
this.#lastProcessedBlock - transaction.blockHeight >
cChainParams.current.confirmsForSaving
) {
const db = await Database.getInstance();
await db.storeTx(transaction, this.getKeyToExport());
}
Expand Down
4 changes: 4 additions & 0 deletions tests/unit/wallet/transactions.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,8 @@ describe('Wallet transaction tests', () => {
0.05 * 10 ** 8,
{ useShieldInputs: true }
);
// Reset blocktime for tests
tx.blockTime = -1;
expect(tx).toStrictEqual(
new Transaction({
version: 3,
Expand All @@ -319,6 +321,8 @@ describe('Wallet transaction tests', () => {
const tx = wallet.createTransaction(addr, 0.05 * 10 ** 8, {
useShieldInputs: true,
});
// Reset blocktime for tests
tx.blockTime = -1;
expect(tx).toStrictEqual(
new Transaction({
version: 3,
Expand Down
Loading