chore: bump the patch group with 2 updates - #6196
Conversation
Bumps the patch group with 4 updates: [futures](https://github.com/rust-lang/futures-rs), [mdbook-core](https://github.com/rust-lang/mdBook), [mdbook-preprocessor](https://github.com/rust-lang/mdBook) and [pulldown-cmark-to-cmark](https://github.com/Byron/pulldown-cmark-to-cmark). Updates `futures` from 0.3.33 to 0.3.34 - [Release notes](https://github.com/rust-lang/futures-rs/releases) - [Changelog](https://github.com/rust-lang/futures-rs/blob/main/CHANGELOG.md) - [Commits](rust-lang/futures-rs@0.3.33...0.3.34) Updates `mdbook-core` from 0.5.2 to 0.5.4 - [Release notes](https://github.com/rust-lang/mdBook/releases) - [Changelog](https://github.com/rust-lang/mdBook/blob/master/CHANGELOG.md) - [Commits](rust-lang/mdBook@v0.5.2...v0.5.4) Updates `mdbook-preprocessor` from 0.5.2 to 0.5.4 - [Release notes](https://github.com/rust-lang/mdBook/releases) - [Changelog](https://github.com/rust-lang/mdBook/blob/master/CHANGELOG.md) - [Commits](rust-lang/mdBook@v0.5.2...v0.5.4) Updates `pulldown-cmark-to-cmark` from 22.0.0 to 22.0.1 - [Release notes](https://github.com/Byron/pulldown-cmark-to-cmark/releases) - [Changelog](https://github.com/Byron/pulldown-cmark-to-cmark/blob/main/CHANGELOG.md) - [Commits](Byron/pulldown-cmark-to-cmark@v22.0.0...v22.0.1) --- updated-dependencies: - dependency-name: futures dependency-version: 0.3.34 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: patch - dependency-name: mdbook-core dependency-version: 0.5.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: patch - dependency-name: mdbook-preprocessor dependency-version: 0.5.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: patch - dependency-name: pulldown-cmark-to-cmark dependency-version: 22.0.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: patch ... Signed-off-by: dependabot[bot] <support@github.com>
prql-bot
left a comment
There was a problem hiding this comment.
Lockfile-only bump; all 16 changed/added checksums verify against the crates.io sparse index, and the lockfile is internally consistent (toml_datetime correctly disambiguated between 0.7.5+spec-1.1.0 for toml_edit and 1.1.1+spec-1.1.0 for toml; no orphaned entries — hashbrown 0.15.5 still has consumers after indexmap moved to 0.17.1). None of the churned crates (toml, indexmap, hashbrown, syn) is a direct workspace dependency, and mdbook-core/mdbook-preprocessor stay within the "0.5.2" caret requirement in web/book/Cargo.toml, so no manifest change is needed.
Approving on the diff. check-ok-to-merge currently shows red, but that check run belongs to run 31891399745, whose own conclusion is cancelled — the concurrency group replaced it and its if: always() gate resolved to failure because its contributors were cancelled, not because anything failed. The replacement run is in flight and will re-register the gate.
Still unverified when I stopped polling (all required-or-relevant, none failing): test-msrv (queued — the one most worth watching here, since toml 1.1.4, indexmap 2.14.0 and hashbrown 0.17.1 are new floors against the workspace's rust-version = "1.81.0"), test-rust, test-deps-min-versions, check-links-markdown, and the nightly/* matrix.
mdbook-core 0.5.4 requires toml ^1.1.2, which requires indexmap ^2.13.0. Every indexmap from 2.12 on declares rust-version 1.82 or later (2.14.0 declares 1.85), and indexmap reaches prqlc through serde_yaml, so the docs-toolchain bump pushed the compiler crate past the workspace's rust-version = "1.81.0" and broke test-msrv. Keep futures 0.3.34 and pulldown-cmark-to-cmark 22.0.1, which stay within the MSRV. Verified with `cargo +1.81.0 check --locked` in prqlc/prqlc.
CI failed — test-msrv broke on the mdbook-core 0.5.4 -> toml 1.x -> indexmap 2.14 chain, which pushes prqlc past the 1.81.0 MSRV. Fix pushed as 73c8d0c.
prql-bot
left a comment
There was a problem hiding this comment.
test-msrv went red after I approved, so I've dismissed that approval and pushed a fix.
The break is mdbook-core 0.5.4, not any of the crates the title names. mdbook-core 0.5.4 requires toml ^1.1.2; toml 1.1.4 requires indexmap ^2.13.0; and every indexmap from 2.12 on declares rust-version = 1.82 (2.14.0 declares 1.85, and it drags in hashbrown 0.17.1, also 1.85). Because the workspace shares one lockfile and indexmap reaches prqlc through serde_yaml — a normal dependency of both prqlc and prqlc-parser — a docs-toolchain bump raised the floor under the compiler crate, past the rust-version = "1.81.0" in Cargo.toml that test-msrv verifies.
I've rebuilt the lockfile with futures 0.3.34 and pulldown-cmark-to-cmark 22.0.1 only, holding mdbook-core/mdbook-preprocessor at 0.5.2. That drops the diff to 21 changed lines, all version/checksum pairs, and cargo +1.81.0 check --locked in prqlc/prqlc — the exact command cargo msrv verify runs — passes. I've retitled the PR to match what it now carries.
Worth a maintainer decision separately: mdBook is now permanently out of reach, not just this week. mdbook-core 0.5.3 and 0.5.4 both declare rust-version = 1.88.0 themselves, and there's no 0.5.x that both postdates 0.5.2 and stays under the current MSRV — so Dependabot will keep re-proposing this bump every week and it will keep failing test-msrv. The two ways out are raising the workspace MSRV (the note above update-rust-toolchain says that's bumped by hand as debian/winget catch up) or adding an ignore entry for mdbook-* in .github/dependabot.yaml alongside the existing max-sixty/tend one. I didn't do either — both are policy calls rather than mechanical fixes.
Evidence and verification notes
Resolver refusal that pins the chain, from cargo update -p indexmap --precise 2.11.4 on the original lockfile:
error: failed to select a version for the requirement `indexmap = "^2.13.0"`
candidate versions found which didn't match: 2.11.4
required by package `toml v1.1.4+spec-1.1.0`
... which satisfies dependency `toml = "^1.1.2"` (locked to 1.1.4+spec-1.1.0) of package `mdbook-core v0.5.4`
... which satisfies dependency `mdbook-core = "^0.5.2"` (locked to 0.5.4) of package `mdbook-prql v0.13.15 (web/book)`
Path from indexmap into the compiler crate (cargo tree -i indexmap -e normal, run in prqlc/prqlc):
indexmap v2.14.0
└── serde_yaml v0.9.34+deprecated
├── prqlc v0.13.15
└── prqlc-parser v0.13.15
└── prqlc v0.13.15
rust-version as declared on crates.io: indexmap 2.11.4 → 1.63, 2.12.0–2.13.1 → 1.82, 2.14.0 → 1.85; hashbrown 0.15.5 → 1.65, 0.17.1 → 1.85; mdbook-core 0.5.2 and 0.5.4 → 1.88.0. The futures 0.3.34 crates and pulldown-cmark-to-cmark 22.0.1 all stay at 1.71/1.71.1, which is why they're safe to keep. futures-macro 0.3.34 switches to syn 3, but syn 3.0.3 was already in the lockfile and declares 1.71.
Why the original lockfile got here at all: a plain cargo update -p futures -p pulldown-cmark-to-cmark reports Locking 10 packages to latest Rust 1.81.0 compatible versions — cargo's MSRV-aware resolver would not have selected these versions. Dependabot resolves with --precise per package, which bypasses that fallback, so it can propose a group that cargo itself would decline.
On the original head I also verified all 16 changed/added checksums against the crates.io sparse index (all matched) and confirmed the lockfile was internally consistent — toml_datetime correctly disambiguated between 0.7.5+spec-1.1.0 and 1.1.1+spec-1.1.0, no orphaned entries. The problem was never lockfile integrity.
prql-bot
left a comment
There was a problem hiding this comment.
test-msrv is green on 73c8d0ce, along with the rest of the rollup (66 success, 17 skipped, 0 failures). Re-approving; the diff is now futures 0.3.33 → 0.3.34 and pulldown-cmark-to-cmark 22.0.0 → 22.0.1, 21 lines of version/checksum pairs.
Note for whoever merges: the mdbook-core/mdbook-preprocessor 0.5.4 bump Dependabot originally grouped in here is held back, and will keep coming back weekly until the MSRV question above is settled.
Bumps the patch group with 4 updates: futures, mdbook-core, mdbook-preprocessor and pulldown-cmark-to-cmark.
Updates
futuresfrom 0.3.33 to 0.3.34Release notes
Sourced from futures's releases.
Changelog
Sourced from futures's changelog.
Commits
705e6b5Release 0.3.34616dac7compat: Inline RawWaker clone function4176369Inline remaining RawWaker clone functionsf17a895Fix cloned FuturesUnordered waker identity51d62admacro: bumpsynto v3 (#3028)9e26177ci: Reduce timeout-minutesb2d0983tsan: Enable Adaptive Delayf733d0eMiri: Ignore compat testse5def2fRename default branch to mainUpdates
mdbook-corefrom 0.5.2 to 0.5.4Release notes
Sourced from mdbook-core's releases.
Changelog
Sourced from mdbook-core's changelog.
... (truncated)
Commits
2ea30c0Merge pull request #3155 from ehuss/bump-versiona08ba2bBump version to 0.5.40e5ddf6Merge pull request #3154 from ehuss/ci-version-stringf4ddbffShow the correct version in CI install docs8b53f1bMerge pull request #3127 from GuillaumeGomez/zoom-inbeab2faMention zoom-in feature in mdbook guide588066cMake the "zoom in" feature work with keyboard and simplify DOMf526b18Only enable "zoom-in" feature on images not inside links73d6edfAdd possibility to "zoom out" using the escape key6a7ef4dAdd regression test for the "zoom-in" featureUpdates
mdbook-preprocessorfrom 0.5.2 to 0.5.4Release notes
Sourced from mdbook-preprocessor's releases.
Changelog
Sourced from mdbook-preprocessor's changelog.
... (truncated)
Commits
2ea30c0Merge pull request #3155 from ehuss/bump-versiona08ba2bBump version to 0.5.40e5ddf6Merge pull request #3154 from ehuss/ci-version-stringf4ddbffShow the correct version in CI install docs8b53f1bMerge pull request #3127 from GuillaumeGomez/zoom-inbeab2faMention zoom-in feature in mdbook guide588066cMake the "zoom in" feature work with keyboard and simplify DOMf526b18Only enable "zoom-in" feature on images not inside links73d6edfAdd possibility to "zoom out" using the escape key6a7ef4dAdd regression test for the "zoom-in" featureUpdates
pulldown-cmark-to-cmarkfrom 22.0.0 to 22.0.1Release notes
Sourced from pulldown-cmark-to-cmark's releases.
Changelog
Sourced from pulldown-cmark-to-cmark's changelog.
Commits
66f7c5dRelease pulldown-cmark-to-cmark v22.0.141f854bMerge pull request #110 from Byron/escape-in-linkse446742fix: escape brackets in generated link labels (#109)Most Recent Ignore Conditions Applied to This Pull Request
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions