Merged
Conversation
nickwinder
reviewed
Feb 2, 2026
Contributor
nickwinder
left a comment
There was a problem hiding this comment.
Quick pass. Worth answering my comment before I look again
Co-authored-by: Nick Winder <nfxdevelopment@gmail.com>
Co-authored-by: Nick Winder <nfxdevelopment@gmail.com>
Replace the ambiguous FileInputWithUrl name with explicit type aliases: - LocalFileInput = Path | bytes | BinaryIO (unchanged) - UrlFileInput = str (new, explicit URL type) - FileInput = UrlFileInput | LocalFileInput (combined, replaces FileInputWithUrl) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Code reviewFound 2 issues:
nutrient-dws-client-python/src/nutrient_dws/client.py Lines 1669 to 1692 in 211377e
nutrient-dws-client-python/src/nutrient_dws/client.py Lines 1424 to 1435 in 211377e 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
- rotate(): change `start > 0` to `start != 0` so prefix pages are included when a negative start index is used (e.g. start=-3) - delete_pages(): rewrite keep-range algorithm to handle negative delete indices; previously all-negative inputs raised a spurious ValidationError instead of keeping the correct page range Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- pyproject.toml: add D102 to tests/* per-file-ignores so test methods are not required to have docstrings (the comment indicated this intent but the empty array had no effect) - test_client.py: remove unused `result` assignment in test_password_protect_pdf_with_permissions Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
nickwinder
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply similar changes to PSPDFKit-labs/nutrient-dws-client-typescript#8
Cutting for release under v3.0