refactor: store api keys in a SecretString#40
Merged
PTFOPlayer merged 1 commit intoJun 29, 2026
Conversation
- Add local `SecretString` type, which
- redacts the secret in `Debug` implementation
- centralises masking implementation
- Use `SecretString` for existing secrets
**NOTE**: Since TinyHarness aims to avoid pulling in external
dependencies where feasible, this recreates minimal functionality from
the `secrecy` crate. The local implementation isn't as flexible or
secure as the external crate's, but should be sufficient for the use
case.
**Why?**: Previously, API keys were stored as plain strings, making
leaks in e.g. logs likely, and making inadvertent leaks to models
relatively easy. Revealing a `SecretString` can only be done explicitly,
constraining the potential leak surface.
PTFOPlayer
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SecretStringtype, whichDebugimplementationSecretStringfor existing secretsNOTE: Since TinyHarness aims to avoid pulling in external dependencies where feasible, this recreates minimal functionality from the
secrecycrate. The local implementation isn't as flexible or secure as the external crate's, but should be sufficient for the use case.Why?: Previously, API keys were stored as plain strings, making leaks in e.g. logs likely, and making inadvertent leaks to models relatively easy. Revealing a
SecretStringcan only be done explicitly, constraining the potential leak surface.