Add iOS-style calculator with Sora font and custom app icon#1
Merged
danascape merged 7 commits intoPVOT-OSS:mainfrom Mar 28, 2026
Merged
Add iOS-style calculator with Sora font and custom app icon#1danascape merged 7 commits intoPVOT-OSS:mainfrom
danascape merged 7 commits intoPVOT-OSS:mainfrom
Conversation
Collaborator
sxivansx
commented
Mar 10, 2026
sxivansx
commented
- Calculator with ViewModel, separate keypad view, and display screen
- iOS-inspired dark theme: black background, orange operators, gray keys
- Sora font (Thin/Light/Regular/Medium) for all UI text
- Minimalist adaptive launcher icon (orange + and white = signs)
- Fixed-size circular buttons computed from screen width for uniform layout
Member
|
danascape
reviewed
Mar 10, 2026
| onBackground = Color(0xFF1C1B1F), | ||
| onSurface = Color(0xFF1C1B1F), | ||
| */ | ||
| private val CalculatorColorScheme = darkColorScheme( |
Collaborator
Author
There was a problem hiding this comment.
sure, will look into how to inherit PVOT lib
| import androidx.compose.ui.unit.sp | ||
| import org.prauga.pvotcalculator.R | ||
|
|
||
| val SoraFamily = FontFamily( |
Member
There was a problem hiding this comment.
Try to implement this in PvotLib and use from there
Collaborator
Author
There was a problem hiding this comment.
will get back on this asap
Member
|
Post screenshots as well |
Member
|
@sxivansx rebase the PR, to make workflow pass and artifact generation |
Collaborator
Author
|
Required for ViewModel integration with Jetpack Compose.
Supports basic arithmetic (+, −, ×, ÷), percent, sign toggle, backspace, clear, and chained operations with expression tracking.
Black background, dark gray digit buttons, light gray function buttons, orange operator buttons. Forces dark-only color scheme.
Includes Thin, Light, Regular, and Medium weights. Applied across all Material typography text styles.
Circular buttons with fixed sizing computed from screen width. iOS layout: function row, 3 digit rows, wide zero button. Communicates via callback lambdas for full decoupling.
CalculatorScreen combines display area (expression + result) with the keypad view. MainActivity sets edge-to-edge dark system bars.
Orange plus sign and white equals sign on dark background. Centered within adaptive icon safe zone to avoid clipping.
Member
|
@sxivansx we can merge this for now, Ill redo your changes, but in future, we have to draft the layout for Tablet and foldable as well |
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.