Conversation
mrivi
changed the title
|
@hamishwillee - Your feedback would be much appreciated! Thanks! |
README.md
Outdated
| ## Installation | ||
|
|
||
| ### Script Installation (Recommended) | ||
| 1. Go to the [PX4 Development Guide](https://dev.px4.io/v1.8.2/en/setup/dev_env_linux.html#gazebo-with-ros) and run the Gazebo with ROS installation script |
There was a problem hiding this comment.
This is a specific version of the setup for PX4 1.8. Not sure if that is intentional. Master is at http://dev.px4.io/master/en/setup/dev_env_linux_ubuntu.html#rosgazebo
There was a problem hiding this comment.
Also, did you test these? I've been running into problems on the other scripts due to recent CMAKE/Python issues
ie nothing wrong with your steps, just that the scripts might have been broken underneath you.
There was a problem hiding this comment.
Yes, it was intentional. That's the last script that installs ROS Kinetic instead of Melodic. I didn't test the entire thing yet
There was a problem hiding this comment.
Sounds good! Up to you if you want to spell that out in a note (i.e. so that people don't just use master version without thinking about it.
| @@ -0,0 +1,9 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
FWIW Don't know what is standard, but generally I quite like it if scripts have brief docs about what they do/when they are used. Maybe a link to where this is defined.
Entirely up to you
README.md
Outdated
| roslaunch global_planner global_planner_depth-camera.launch | ||
| ``` | ||
|
|
||
| Alternitavely you can follow the step by step instructions in the following sections. |
There was a problem hiding this comment.
Typo Alternitavely > Alternatively
README.md
Outdated
| ``` bash | ||
| source install_avoidance.sh | ||
| ``` | ||
| To run the local planner |
There was a problem hiding this comment.
I assume we just want to run one of the planners? Might be better to make that clear like this
- Run the desired planner:
- Local planner:
roslaunch local_planner local_planner_sitl_3cam.launch
- Safe landing planner
roslaunch safe_landing_planner safe_landing_planner.launch
- Global planner
roslaunch global_planner global_planner_depth-camera.launch
- Local planner:
README.md
Outdated
| ```bash | ||
| roslaunch safe_landing_planner safe_landing_planner.launch | ||
| ``` | ||
| To run the safe global planner |
There was a problem hiding this comment.
"Safe" global planner?
|
Looks great, and good idea. I'm a fan of scripted installation (and even more of proper app packages). A few minor comments inline |
2 participants
The PR provides the users with an installation script to be run after ROS and PX4 Toolchain are installed to quickly setup the avoidance package