Fixed fastrtps version reading in microRTPS generation for ROS2 built from sources#155
Open
abarcis wants to merge 1 commit into
Open
Fixed fastrtps version reading in microRTPS generation for ROS2 built from sources#155abarcis wants to merge 1 commit into
abarcis wants to merge 1 commit into
Conversation
Signed-off-by: Agata Barcis <agata.barcis@tii.ae>
TSC21
requested changes
Sep 9, 2022
Member
TSC21
left a comment
TSC21
left a comment
There was a problem hiding this comment.
Can you please do this change on the PX4-Autopilot repo instead? The script is deployed from there since it's the source script. Thanks
Contributor
Author
|
Thank you for such a fast reply! I've just opened a PR to PX4-Autopilot: PX4/PX4-Autopilot#20183 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When ROS2 is built from sources the dpkg check of fastrtps version was failing and stopping microRTPS bridge generation. After fix, in such a case, the system-wide version will be used