Added context and changed parameter structure to object#15
Open
supachris28 wants to merge 4 commits into
Open
Conversation
Contributor
Author
|
Please read the above comment. This will require some consideration as to whether it is appropriate as is, even as a major version bump. |
aashutoshbane
previously approved these changes
Feb 17, 2020
Rahul-Barick-packt
previously approved these changes
Feb 17, 2020
afareed007
previously approved these changes
Feb 17, 2020
AStevensTaylor
previously approved these changes
Feb 19, 2020
bb57788
aashutoshbane
approved these changes
Mar 30, 2020
Rahul-Barick-packt
approved these changes
Mar 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added a context object (as any) to allow an error to be logged with more context information about what was going on. I've added this as a further parameter, but I've also changes it so the first parameter can either be a message or a config object to save you doing the following:
Now you can do:
This does have the knock on effect that
statusCodeanderrorCodeare optional in the main signature, but they are still validated to exist at runtime, but it deconstructs them from the config object first.