Merge gh bb#10
Open
supachris28 wants to merge 10 commits into
Open
Conversation
Feature/dotenv Approved-by: Mike Elsmore <mike@elsmore.me> Approved-by: Chris Key <chrisk@packtpub.com>
…generator into merge-gh-bb
supachris28
requested review from
a team,
AStevensTaylor,
DRKRahul,
Dhirajpackt,
YasPop,
aashutoshbane,
abhishekpal1993,
brosell1,
jojov92,
kgbland and
surfthakur
| .yarn-integrity | ||
|
|
||
| # dotenv environment variables file | ||
| .env |
There was a problem hiding this comment.
@supachris28, why has this been removed?
Author
There was a problem hiding this comment.
There is no runtime for this, it is a module, so no real env variables to be used. I've added a .env to be used for testing to ensure it works as expected.
afareed007
reviewed
Apr 1, 2020
afareed007
left a comment
afareed007
left a comment
There was a problem hiding this comment.
A minor thing: console.log can be replaced with the debug in this file :)
afareed007
approved these changes
Apr 1, 2020
aashutoshbane
approved these changes
Apr 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.