Feat/24 gateway 모니터링 설정 - #25
Merged
Merged
Conversation
Closed
github-actions
Bot
requested review from
M1Nj1M,
gnoesnooj,
hhegi,
jsh9057 and
soo96
May 20, 2026 05:07
📝 WalkthroughWalkthroughPrometheus 메트릭 레지스트리 의존성을 추가하고 Spring Actuator 관리 엔드포인트 설정을 통해 헬스, 메트릭, Prometheus 데이터 노출 및 Zipkin 분산 추적 샘플링과 엔드포인트를 구성합니다. Changes모니터링 및 추적 활성화
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 분 Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
soo96
approved these changes
May 20, 2026
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/main/resources/application.yml (1)
120-125: ⚡ Quick win추적 설정을 환경변수 기반으로 분리해 운영 리스크를 줄이세요.
Line 122, Line 125가 고정값(1.0, localhost)이라 환경별 운영이 어렵고, 실서비스에서 비용/성능 부담이 커질 수 있습니다. 기본값을 두되 환경 변수로 오버라이드 가능하게 바꾸는 편이 안전합니다.
권장 수정 예시
tracing: sampling: - probability: 1.0 + probability: ${MANAGEMENT_TRACING_SAMPLING_PROBABILITY:0.1} zipkin: tracing: - endpoint: http://localhost:9411/api/v2/spans + endpoint: ${MANAGEMENT_ZIPKIN_TRACING_ENDPOINT:http://zipkin:9411/api/v2/spans}🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/main/resources/application.yml` around lines 120 - 125, The tracing configuration uses hardcoded values; change tracing.sampling.probability and zipkin.tracing.endpoint to use environment-variable placeholders with sensible defaults (e.g., ${TRACING_SAMPLING_PROBABILITY:1.0} and ${ZIPKIN_TRACING_ENDPOINT:http://localhost:9411/api/v2/spans}) so environments can override them at runtime; update any references or docs to accept TRACING_SAMPLING_PROBABILITY and ZIPKIN_TRACING_ENDPOINT and ensure the sampling value is consumed as a number by the code that reads tracing.sampling.probability.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/main/resources/application.yml`:
- Around line 104-109: The actuator configuration currently exposes sensitive
endpoints (gateway/metrics/prometheus/health details) while /actuator/** is
publicly accessible; update the application.yml entries so
management.endpoints.web.exposure.include is narrowed (e.g. only "health,info"
or empty), set management.endpoint.health.show-details: when_authorized (not
always), and disable or set management.endpoint.gateway.enabled: false if not
required; additionally ensure your security configuration blocks unauthenticated
access to /actuator/** (adjust the public path that currently exposes
/actuator/** to require authentication or a specific role).
---
Nitpick comments:
In `@src/main/resources/application.yml`:
- Around line 120-125: The tracing configuration uses hardcoded values; change
tracing.sampling.probability and zipkin.tracing.endpoint to use
environment-variable placeholders with sensible defaults (e.g.,
${TRACING_SAMPLING_PROBABILITY:1.0} and
${ZIPKIN_TRACING_ENDPOINT:http://localhost:9411/api/v2/spans}) so environments
can override them at runtime; update any references or docs to accept
TRACING_SAMPLING_PROBABILITY and ZIPKIN_TRACING_ENDPOINT and ensure the sampling
value is consumed as a number by the code that reads
tracing.sampling.probability.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: afde8e6d-1a57-4713-9469-44a6324690ce
📒 Files selected for processing (2)
build.gradlesrc/main/resources/application.yml
Comment on lines
+104
to
+109
| include: health, info, metrics, prometheus, gateway | ||
| endpoint: | ||
| health: | ||
| show-details: always | ||
| gateway: | ||
| enabled: true |
There was a problem hiding this comment.
Actuator 민감 정보가 익명으로 노출될 수 있습니다.
Line 104-109 설정은 gateway/metrics/prometheus와 health 상세정보를 노출합니다. 현재 파일의 Line 97에서 /actuator/**가 공개 경로라, 운영 토폴로지/메트릭이 비인증 사용자에게 열릴 수 있습니다. 운영 환경 기준으로는 최소 노출 + 인증 기반 상세 조회로 제한하는 게 안전합니다.
권장 수정 예시
management:
endpoints:
web:
exposure:
- include: health, info, metrics, prometheus, gateway
+ include: health, prometheus
endpoint:
health:
- show-details: always
+ show-details: when_authorized
gateway:
- enabled: true
+ enabled: false jwt:
public-paths:
- /api/v1/auth/**
- - /actuator/**
- /api/v1/payment/webhook📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| include: health, info, metrics, prometheus, gateway | |
| endpoint: | |
| health: | |
| show-details: always | |
| gateway: | |
| enabled: true | |
| include: health, prometheus | |
| endpoint: | |
| health: | |
| show-details: when_authorized | |
| gateway: | |
| enabled: false |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/main/resources/application.yml` around lines 104 - 109, The actuator
configuration currently exposes sensitive endpoints
(gateway/metrics/prometheus/health details) while /actuator/** is publicly
accessible; update the application.yml entries so
management.endpoints.web.exposure.include is narrowed (e.g. only "health,info"
or empty), set management.endpoint.health.show-details: when_authorized (not
always), and disable or set management.endpoint.gateway.enabled: false if not
required; additionally ensure your security configuration blocks unauthenticated
access to /actuator/** (adjust the public path that currently exposes
/actuator/** to require authentication or a specific role).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
🚀 주요 변경 사항
✅ 자체 체크리스트 (필수)
./gradlew build실행 결과 정상 (인증샷 첨부)📸 테스트 인증샷
💬 리뷰어 전달사항 (선택)
📎 참고 자료
Summary by CodeRabbit
New Features