Skip to content

[FEAT] Support Numscript-WASM new version (v0.1.0)#19

Merged
fermuch merged 8 commits into
mainfrom
feat/update-numscript-wasm-version
Jul 3, 2025
Merged

[FEAT] Support Numscript-WASM new version (v0.1.0)#19
fermuch merged 8 commits into
mainfrom
feat/update-numscript-wasm-version

Conversation

@Vinocis
Copy link
Copy Markdown
Collaborator

@Vinocis Vinocis commented Jul 3, 2025

No description provided.

@Vinocis Vinocis self-assigned this Jul 3, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 3, 2025

Failed to generate code suggestions for PR

@Vinocis Vinocis requested a review from fermuch July 3, 2025 14:48
Copy link
Copy Markdown
Contributor

@fermuch fermuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considero melhor apagar todo o que não é mais compatível. Para que teriamos CheckLog hoje, se não é mais usado?

Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread lib/numscriptex/run.ex Outdated
Comment thread lib/numscriptex/run.ex Outdated
Comment thread lib/numscriptex/run.ex Outdated
@Vinocis Vinocis requested a review from fermuch July 3, 2025 16:33
Copy link
Copy Markdown
Contributor

@fermuch fermuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gostei de como ficou e dos mensagens de erro explicando o field. Os atoms ficaram muito mais claros também!

Comment thread README.md
@Vinocis Vinocis requested a review from fermuch July 3, 2025 19:14
Copy link
Copy Markdown
Contributor

@fermuch fermuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fermuch fermuch merged commit e98b880 into main Jul 3, 2025
4 checks passed
@fermuch fermuch deleted the feat/update-numscript-wasm-version branch July 3, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants