Created Kalman Filter velocity publisher#398
Conversation
|
Reviewed 8 of 8 files at r1. src/localization/CMakeLists.txt, line 22 at r1 (raw file):
There is a missing EOF/endline character in this file. src/localization/robosub_sensors.h, line 35 at r1 (raw file):
The standard that Robosub has been working with for new lines is to align the new line with the portion of the previous line that it belongs in. For instance, here this change is incorrect, the original placement of src/localization/tests/CMakeLists.txt, line 6 at r1 (raw file):
There is an extra newline here. src/localization/tests/localizationSystem.test, line 2 at r1 (raw file):
This is a rather generous timeout. 4 minutes is significant testing time. Is this necessary? src/localization/tests/localizationSystem.test, line 3 at r1 (raw file):
Trailing whitespace. src/localization/tests/localizationSystem.test, line 6 at r1 (raw file):
Missing newline/EOF. src/localization/tests/test_localization_system.cpp, line 21 at r1 (raw file):
This test is extraneous. Why is it here? Comments from Reviewable |
This code creates a publisher to expose the Kalman Filter's internal estimate of linear velocity.
The new data is published on the topic "/localization/debug/kf/linVel"
There are also two trivial spacing issues that were resolved in this commit.
This change is