Properly tuned the new PID parameters#112
Open
ryan-summers wants to merge 3 commits into
Open
Conversation
ryan-summers
force-pushed
the
rsummers/parameter-fix
branch
from
January 5, 2018 20:39
224a806 to
1a75164
Compare
Member
|
Reviewed 2 of 2 files at r1. param/simulator.yaml, line 8 at r1 (raw file):
Why is this so high? Comments from Reviewable |
Member
|
@irwineffect, could you complete your review here so that this can be merged in? @rsummers, the roll test of the control system is currently failing on Travis, is there an explanation for this? Does the test need to be updated? Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed. Comments from Reviewable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parameters were tuned using the Ziegler-Nichols method. I'm really not sure how the old parameters happened to pass the tests with improper derivative calculations, but whatevs! This should fix the heartache of the other AI devs :P The simulator_bridge frequency was increased to ensure that the IMU node publishes faster than 5 Hz (this causes a large lag in the derivative calculation and causes the control system to perform sub-optimally).
This change is