Repository navigation
Conversation
This pull request adds a new "Edit" (trim and crop) feature for media files, allowing users to trim audio/video and crop video files directly from the frontend. The implementation includes backend support for the new job type, frontend UI components and logic for the editor, and updates to documentation and job handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new "edit" feature that allows users to trim and crop audio and video files after processing. The changes span backend job registration, API documentation, frontend logic, UI components, and styling to support this new capability. Below are the most important changes grouped by theme:
Backend/API Support for Edit Jobs
editjob type with the backend job queue, enabling the server to process trim/crop edit requests.editjob type, specifying required parameters (start,end,crop_x,crop_y,crop_w,crop_h,retention_days) and describing the behavior and validation for edit jobs. [1] [2]Frontend Functionality for Editing
frontend/app.jsto manage the editor state, including opening/closing the editor, handling playback, trimming, cropping, and submitting new edit jobs. Utility functions for crop manipulation and time formatting were also introduced. [1] [2] [3] [4] [5]User Interface Enhancements
UI/UX Adjustments
These changes collectively enable users to perform precise post-processing edits (trimming and cropping) on supported media files directly from the frontend, with robust backend support and clear user interface feedback.