Update book details page by Eoic · Pull Request #4 · PapyrusReader/client

Eoic · 2026-02-06T15:40:09Z

Add missing form fields according to the book data model, update form layout, and show missing info in book details page.

… anf update form layout.

… tracking.

…hen physical book flag is set to false.

…sktop view.

Copilot

Pull request overview

This PR updates the Flutter client’s book details and edit experiences to better reflect the Book data model (publisher/publication date/ISBN variants/language/series/rating/physical lending info), and refreshes desktop layouts to match the book details page styling.

Changes:

Expanded book details display (BookInfoGrid, BookHeader) to show subtitle, combined authors, and additional metadata fields.
Extended the edit form (BookEditPage + BookEditProvider) with rating, publication date picker, series fields, and physical/lending fields.
Updated Book model fields/JSON mapping (e.g., cover_image_url, series name/number types).

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
client/lib/widgets/book_edit/cover_image_picker.dart	Tweaks cover sizing/spacing in the cover picker UI.
client/lib/widgets/book_details/book_info_grid.dart	Displays additional metadata (publisher/date/ISBN/language/series/rating/status/location/lending).
client/lib/widgets/book_details/book_header.dart	Shows subtitle and uses combined author display (`allAuthors`).
client/lib/providers/book_edit_provider.dart	Adds update methods + parses/sets `publicationDate` from fetched metadata.
client/lib/pages/book_edit_page.dart	Adds new edit fields (date picker, rating, series, physical/lending) and updates desktop scaffold layout.
client/lib/pages/book_details_page.dart	Aligns desktop header styling with shared app bar sizing/typography.
client/lib/models/book.dart	Adds series name, changes series number to `double?`, and maps cover URL to `cover_image_url` in JSON.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-06T15:46:38Z

client/lib/models/book.dart

  final String? seriesId;
-  final int? seriesNumber;
+  final String? seriesName;
+  final double? seriesNumber;


seriesNumber was changed from int? to double?, but there are existing Book(...) constructions (e.g. in client/lib/data/sample_data.dart) that pass integer literals like seriesNumber: 1, which will no longer type-check and will break the build. Update those call sites to pass doubles (e.g. 1.0) or cast/convert appropriately, and consider whether 0 is still a valid sentinel value now that this is a double?.

Copilot · 2026-02-06T15:46:38Z

client/lib/pages/book_edit_page.dart

+    final picked = await showDatePicker(
+      context: context,
+      initialDate: currentValue ?? DateTime.now(),
+      firstDate: DateTime(1000),
+      lastDate: DateTime.now().add(const Duration(days: 365)),


showDatePicker requires initialDate to be within [firstDate, lastDate]. With lastDate capped at DateTime.now().add(Duration(days: 365)), opening the picker will throw if currentValue is later than that (e.g. a pre-release publication date). Clamp initialDate into range and/or ensure lastDate is at least currentValue when non-null.

Suggested change

final picked = await showDatePicker(

context: context,

initialDate: currentValue ?? DateTime.now(),

firstDate: DateTime(1000),

lastDate: DateTime.now().add(const Duration(days: 365)),

final now = DateTime.now();

final firstDate = DateTime(1000);

final defaultLastDate = now.add(const Duration(days: 365));

// Ensure the lastDate is at least as late as the current value, if any.

final effectiveLastDate = currentValue != null && currentValue.isAfter(defaultLastDate)

? currentValue

: defaultLastDate;

// Choose an initial date and clamp it into [firstDate, effectiveLastDate].

DateTime initialDate = currentValue ?? now;

if (initialDate.isBefore(firstDate)) {

initialDate = firstDate;

} else if (initialDate.isAfter(effectiveLastDate)) {

initialDate = effectiveLastDate;

}

final picked = await showDatePicker(

context: context,

initialDate: initialDate,

firstDate: firstDate,

lastDate: effectiveLastDate,

Copilot · 2026-02-06T15:46:38Z

client/lib/pages/book_edit_page.dart

+          return GestureDetector(
+            onTap: () {
+              _provider.updateRating(starValue == rating ? null : starValue);
+            },
+            child: Padding(
+              padding: const EdgeInsets.symmetric(horizontal: 2),
+              child: Icon(
+                isSelected ? Icons.star_rounded : Icons.star_outline_rounded,
+                color: isSelected
+                    ? colorScheme.primary
+                    : colorScheme.onSurfaceVariant,
+                size: 28,
+              ),


The rating control uses GestureDetector + Icon, which isn’t focusable and doesn’t provide an accessible label/tooltip for screen readers or keyboard users. Prefer IconButton/InkResponse with tooltip/semanticLabel (or wrap with Semantics) so the stars are discoverable and operable via accessibility services.

Suggested change

return GestureDetector(

onTap: () {

_provider.updateRating(starValue == rating ? null : starValue);

},

child: Padding(

padding: const EdgeInsets.symmetric(horizontal: 2),

child: Icon(

isSelected ? Icons.star_rounded : Icons.star_outline_rounded,

color: isSelected

? colorScheme.primary

: colorScheme.onSurfaceVariant,

size: 28,

),

return Padding(

padding: const EdgeInsets.symmetric(horizontal: 2),

child: IconButton(

onPressed: () {

_provider.updateRating(starValue == rating ? null : starValue);

},

icon: Icon(

isSelected ? Icons.star_rounded : Icons.star_outline_rounded,

color: isSelected

? colorScheme.primary

: colorScheme.onSurfaceVariant,

size: 28,

),

padding: EdgeInsets.zero,

tooltip: starValue == rating

? 'Clear rating'

: 'Set rating to $starValue ${starValue == 1 ? 'star' : 'stars'}',

Copilot · 2026-02-06T15:46:39Z

client/lib/pages/book_edit_page.dart

+  String _formatSeriesNumber(double number) {
+    return number == number.roundToDouble()
+        ? number.toInt().toString()
+        : number.toString();
+  }


_formatSeriesNumber is now duplicated here and in BookInfoGrid. To avoid formatting drift, consider moving this into a shared util (or a Book/extension helper) and reusing it from both places.

Copilot · 2026-02-06T15:46:39Z

client/lib/widgets/book_edit/cover_image_picker.dart

                ),
              ),
-              SizedBox(width: widget.isDesktop ? Spacing.xs : Spacing.md),
+              SizedBox(width: widget.isDesktop ? Spacing.md : Spacing.md),


This conditional is redundant (widget.isDesktop ? Spacing.md : Spacing.md). Consider simplifying to a single value (and making the SizedBox const if possible) to reduce noise and keep layout intent clear.

Suggested change

SizedBox(width: widget.isDesktop ? Spacing.md : Spacing.md),

const SizedBox(width: Spacing.md),

Eoic added 4 commits February 6, 2026 16:55

Add missing fields to book metadata form based on the book data model…

abb65cb

… anf update form layout.

Add series name and number fields, implement rating and physical book…

3dfd1f7

… tracking.

Update physical book details layout, do not show physical book info w…

a5830b9

…hen physical book flag is set to false.

Make book details ad edit form app bars have a consistent style in de…

d831d2b

…sktop view.

Eoic self-assigned this Feb 6, 2026

Copilot AI review requested due to automatic review settings February 6, 2026 15:40

Copilot started reviewing on behalf of Eoic February 6, 2026 15:40 View session

Eoic merged commit 7e01324 into master Feb 6, 2026
5 checks passed

Eoic deleted the feature/book-details branch February 6, 2026 15:41

Copilot AI reviewed Feb 6, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update book details page#4

Update book details page#4
Eoic merged 4 commits intomasterfrom
feature/book-details

Eoic commented Feb 6, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 6, 2026

Uh oh!

Copilot AI Feb 6, 2026

Uh oh!

Copilot AI Feb 6, 2026

Uh oh!

Copilot AI Feb 6, 2026

Uh oh!

Copilot AI Feb 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-    final picked = await showDatePicker(
-      context: context,
-      initialDate: currentValue ?? DateTime.now(),
-      firstDate: DateTime(1000),
-      lastDate: DateTime.now().add(const Duration(days: 365)),
+    final now = DateTime.now();
+    final firstDate = DateTime(1000);
+    final defaultLastDate = now.add(const Duration(days: 365));
+    // Ensure the lastDate is at least as late as the current value, if any.
+    final effectiveLastDate = currentValue != null && currentValue.isAfter(defaultLastDate)
+        ? currentValue
+        : defaultLastDate;
+    // Choose an initial date and clamp it into [firstDate, effectiveLastDate].
+    DateTime initialDate = currentValue ?? now;
+    if (initialDate.isBefore(firstDate)) {
+      initialDate = firstDate;
+    } else if (initialDate.isAfter(effectiveLastDate)) {
+      initialDate = effectiveLastDate;
+    }
+    final picked = await showDatePicker(
+      context: context,
+      initialDate: initialDate,
+      firstDate: firstDate,
+      lastDate: effectiveLastDate,

	SizedBox(width: widget.isDesktop ? Spacing.md : Spacing.md),
	const SizedBox(width: Spacing.md),

Conversation

Eoic commented Feb 6, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants