Mapping nagold bike converter#377
Open
AbdullahiFatola wants to merge 3 commits into
Open
Conversation
Updated field descriptions for 'Strasse', 'Lagebeschr', 'Beleuchtun', 'Ueberdachu', and 'Ueberwachu' to clarify their usage as parking facility names and descriptions.
ThorstenFroehlinghaus
suggested changes
May 21, 2026
|
|
||
| Each bicycle parking installation is mapped to a static `ParkingSite` as follows. | ||
| Attributes which are set statically by the converter: | ||
|
|
Collaborator
There was a problem hiding this comment.
purposeis alwaysBIKE
| Each bicycle parking installation is mapped to a static `ParkingSite` as follows. | ||
| Attributes which are set statically by the converter: | ||
|
|
||
| * `has_realtime_data` is always set to `False` |
Collaborator
There was a problem hiding this comment.
false
Please use always true/false instead of True/False.
|
|
||
| Static values: | ||
|
|
||
| Each bicycle parking installation is mapped to a static `ParkingSite` as follows. |
Collaborator
There was a problem hiding this comment.
ignore parking installation with "Stellplatz": " " and "Anzahl_Bue": 0
| |----------------------|--------------| | ||
| | Anlehnbügel | `STANDS` | | ||
| | Vorderradanschluss | `WALL_LOOPS` | | ||
| | None | `STANDS` | |
Collaborator
There was a problem hiding this comment.
not needed. This parking installation has "Anzahl_Bue": 0
| | Lagebeschr | string | ? | description | Parking description (e.g. "Am Parkplatz vom Polizeirevier") | | ||
| | coordinates[1] | numeric | 1 | lat | GeoJSON geometry coordinates index 1 | | ||
| | coordinates[0] | numeric | 1 | lon | GeoJSON geometry coordinates index 0 | | ||
| | Stellplatz | [Stellplatz](#Stellplatz) | ? | type | See [Stellplatz](#Stellplatz) | |
Collaborator
There was a problem hiding this comment.
Cardinality: 1
same for other attributes. "1" means data are always available, even if they are optional for ParkAPI.
| | Anzahl_Lad | integer | ? | [restrictions](#ParkingSiteRestriction) | Map to `CHARGING` restrictions if > 0 | | ||
| | Beleuchtun | [Beleuchtung](#Beleuchtung) | ? | has_lighting | See [Beleuchtung](#Beleuchtung) | | ||
| | Ueberdachu | [Ueberdachung](#Ueberdachung) | ? | is_covered | See [Ueberdachung](#Ueberdachung) | | ||
| | Bike_and_R | [Bike_and_Ride](#Bike_and_Ride) | ? | park_and_ride_type | See [Bike_and_Ride](#Bike_and_Ride) | |
Collaborator
There was a problem hiding this comment.
use ParkAndRideType instead of Bike_and_Ride. Otherwise link does not work.
| | Ueberwachu | [Ueberwachung](#Ueberwachung) | ? | supervision_type | See [Ueberwachung](#Ueberwachung) | | ||
| | Betreiber | string | ? | operator_name | Omit if blank | | ||
| | last_edi_1 | epoch ms | ? | static_data_updated_at | Convert epoch milliseconds to ISO 8601 | | ||
| | created_da | epoch ms | ? | static_data_updated_at | Fallback if `last_edi_1` is not available | |
Collaborator
There was a problem hiding this comment.
last_edi_1 is always available, so we don't need created_da
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates mapping for the integration of bicycle parking data from the city of Nagold