Fixed bug that allowed multiple subscriptions to created/edited simultaneously #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you were in the process of setting up a subscription (or had just viewed you subscription) and then entered a command to start a different subscription, collectors for both will be open and things get a bit confusing. This PR adds a check to see if a command entered during a subscription beings with the bot prefix. If it does, the current subscription will be canceled. Additionally, in this scenario both messages.js and collect_option.js or collect_detail.js would try to delete the same message, resulting in an error. I'm not sure why the try...catch doesn't work, but it wasn't. So I added another check for the bot prefix before collect_option.js or collect_detail.js tries to delete that message.