Normalize boolish persisted config flags#1164
Conversation
|
Warning Review limit reached
Your plan includes 2 reviews of capacity. Refill in 14 minutes and 46 seconds. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more review capacity refills, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (11)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Migrated from Pasta-Devs/Marinara-Engine-Refactor#17: Pasta-Devs/Marinara-Engine-Refactor#17
Original author: @Promansis
Target base: Pasta-Devs/Marinara-Engine refactor
Source draft state: False
Verification after port:
pnpm typecheckPort note: source updates/ tracker/evidence files were omitted because the target refactor branch removed repo-local updates guidance.
Summary
Root Cause
Some persisted configuration readers only treated string
"true"as enabled, while current writers and engine contracts use booleantrue. That made UI state and resolver state diverge for random-pool membership and prompt preset defaults.Validation
pnpm typecheckgit diff --checkuseForRandom,isDefault, anddefaultequality checks insrc/featuresandsrc/engine.