Skip to content

Normalize boolish persisted config flags#1164

Merged
cha1latte merged 1 commit into
refactorfrom
fix/refactor-pr-17-boolish-config
May 24, 2026
Merged

Normalize boolish persisted config flags#1164
cha1latte merged 1 commit into
refactorfrom
fix/refactor-pr-17-boolish-config

Conversation

@munimunigamer

Copy link
Copy Markdown
Collaborator

Migrated from Pasta-Devs/Marinara-Engine-Refactor#17: Pasta-Devs/Marinara-Engine-Refactor#17
Original author: @Promansis
Target base: Pasta-Devs/Marinara-Engine refactor
Source draft state: False
Verification after port: pnpm typecheck
Port note: source updates/ tracker/evidence files were omitted because the target refactor branch removed repo-local updates guidance.


Summary

  • Normalize persisted boolish reads for connection random-pool membership across connection UI, quick switchers, and dependent random/default connection resolvers.
  • Normalize prompt preset default reads so boolean defaults show the default badge and are found by default preset lookup.
  • Record local bug ownership/status for the two boolean configuration issues.

Root Cause

Some persisted configuration readers only treated string "true" as enabled, while current writers and engine contracts use boolean true. That made UI state and resolver state diverge for random-pool membership and prompt preset defaults.

Validation

  • pnpm typecheck
  • git diff --check
  • Searched for remaining strict useForRandom, isDefault, and default equality checks in src/features and src/engine.

@coderabbitai

coderabbitai Bot commented May 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@cha1latte, we couldn't start this review because you've used your available PR reviews for now.

Your plan includes 2 reviews of capacity. Refill in 14 minutes and 46 seconds.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more review capacity refills, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b688b6d4-29a2-470d-a8a8-58f875eaea57

📥 Commits

Reviewing files that changed from the base of the PR and between 99c21dc and f244f11.

📒 Files selected for processing (11)
  • src/engine/generation/context.ts
  • src/engine/modes/chat/core/summaries/auto-summary.service.ts
  • src/engine/modes/chat/schedules/schedule.service.ts
  • src/engine/modes/roleplay/scene/scene-service.ts
  • src/features/catalog/chats/hooks/use-chats.ts
  • src/features/catalog/presets/components/PresetsPanel.tsx
  • src/features/catalog/presets/hooks/use-presets.ts
  • src/features/modes/shared/chat-ui/components/ChatSettingsDrawer.tsx
  • src/features/modes/shared/chat-ui/components/QuickConnectionSwitcher.tsx
  • src/features/modes/shared/chat-ui/components/QuickSwitcherMobile.tsx
  • src/features/shell/connections/components/ConnectionsPanel.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/refactor-pr-17-boolish-config

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the bugfix Bug fix label May 24, 2026
@cha1latte cha1latte self-assigned this May 24, 2026
@cha1latte

Copy link
Copy Markdown
Contributor

@coderabbitai review

@coderabbitai

coderabbitai Bot commented May 24, 2026

Copy link
Copy Markdown
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@cha1latte cha1latte merged commit 2cb6e0c into refactor May 24, 2026
6 checks passed
@cha1latte cha1latte deleted the fix/refactor-pr-17-boolish-config branch May 24, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants