[codex] fix character cache churn#1168
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated from Pasta-Devs/Marinara-Engine-Refactor#54: Pasta-Devs/Marinara-Engine-Refactor#54
Original author: @Promansis
Target base: Pasta-Devs/Marinara-Engine refactor
Source draft state: True
Verification after port:
pnpm typecheckPort note: source updates/ tracker/evidence files were omitted because the target refactor branch removed repo-local updates guidance.
Closes #39
Why this change
Character import and delete paths were refreshing the full character list even when the mutation response already contained enough data to patch the React Query cache. That caused avoidable refetch churn in the character UI.
What changed
Validation
pnpm typecheckpnpm checkpnpm tauri devand tested the app path manuallyManual verification notes
Codex verification:
pnpm checkpassed on PR head in an isolated worktree.upstream/refactorinto the PR head merged cleanly.pnpm checkpassed after that local merge proof.Manual follow-up:
Docs impact
UI evidence
N/A. Cache behavior change; no reviewer-visible UI screenshot captured.