Skip to content

fix/wire in agents debug mode logging#1171

Merged
cha1latte merged 2 commits into
refactorfrom
fix/refactor-pr-57-agent-debug-logging
May 25, 2026
Merged

fix/wire in agents debug mode logging#1171
cha1latte merged 2 commits into
refactorfrom
fix/refactor-pr-57-agent-debug-logging

Conversation

@munimunigamer

Copy link
Copy Markdown
Collaborator

Migrated from Pasta-Devs/Marinara-Engine-Refactor#57: Pasta-Devs/Marinara-Engine-Refactor#57
Original author: @Promansis
Target base: Pasta-Devs/Marinara-Engine refactor
Source draft state: True
Verification after port: pnpm typecheck
Port note: the source branch included an inherited avatar-crop commit; this target branch ports the debug-logging work only because Refactor PR #55 is migrated separately.


Linked issue

Fixes #34

Why this change

This adds visible debug-mode output for agent execution so prompt, response, tool-call, tool-result, and batch details can be inspected in the in-app agent debug panel during generation.

What changed

  • Wired debugMode and debugSink through the TypeScript generation/agent runtime.
  • Added structured agent debug entries in the engine so debug information is collected centrally instead of being silent.
  • Updated the settings help text to describe the in-app debug panel.
  • Moved the agent debug entry type into the shared engine contract.

Validation

  • pnpm typecheck
  • pnpm build
  • cargo check --manifest-path src-tauri/Cargo.toml
  • pnpm check:docs when docs, skills, or repo guidance changed
  • Ran pnpm tauri dev and tested the app path manually
  • Verified the affected feature in the right mode(s): chat, roleplay, game, settings/providers, imports/exports, or assets

Manual verification notes

Not run in this handoff.

Docs impact

  • No docs changes needed
  • Updated docs/developer/* or repo guidance as needed

UI evidence

@coderabbitai

coderabbitai Bot commented May 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c356a199-70d9-4ef7-a809-52e408681bf7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/refactor-pr-57-agent-debug-logging

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the bugfix Bug fix label May 24, 2026
@cha1latte cha1latte self-requested a review May 25, 2026 20:50
@cha1latte cha1latte marked this pull request as ready for review May 25, 2026 21:57
@cha1latte cha1latte merged commit f2b335b into refactor May 25, 2026
6 checks passed
@cha1latte cha1latte deleted the fix/refactor-pr-57-agent-debug-logging branch May 25, 2026 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants