Fix useless extension parameter in constructor#20
Open
SidShakal wants to merge 1 commit intoPatPeter:masterfrom
Open
Fix useless extension parameter in constructor#20SidShakal wants to merge 1 commit intoPatPeter:masterfrom
SidShakal wants to merge 1 commit intoPatPeter:masterfrom
Conversation
This change fixes the "extension" parameter having no effect in FilenameDatabase(Logger log, String prefix, DBMS dbms, String directory, String filename, String extension). This fix will affect any derived classes that call this constructor as well, such as SQLite and H2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes setExtension(String extension) so it actually sets the extension field.
As a result, the "extension" parameter will actually behave as intended in the FilenameDatabase(Logger log, String prefix, DBMS dbms, String directory, String filename, String extension) constructor.
In turn, any derived classes that call this constructor as well, such as SQLite and H2, will work as was intended.
On the down-side, any plugins that currently call this constructor with an extension other than ".db" will create a new database upon updating to a version of SQLibrary that includes this patch. Any server administrators affected by this should overwrite the newly created database with the old one (which would not be overwritten, as the extension will be different).