feat: add empty state UI and logic for favorites page#525
Open
akshigalav wants to merge 2 commits into
Open
Conversation
Author
|
Hi! @PatelHarsh2006 Just a reminder to review my PR #525. Please review my PR I'd appreciate any feedback, and if everything looks good, I'd be grateful if it could be merged. |
Author
|
Hi! @PatelHarsh2006, I have resolved all the conflicts with the base branch. Kindly review and merge my PR. I am a contributor in GSSoC '26. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
### Description:
In this PR i have addressed the issue of empty favorites page when nothing has been added in favorites, it displays a blank screen when no favorites are saved. I have updated that thing as it didn't look quite appealing.
### Changes Made
favorites.html): Added the empty state structure and positioned it outside the dynamic container to prevent it from being cleared by JavaScript.css/style.css): Styled the empty state using Flexbox for spacing, padding, and layout centering.js/main.js): UpdatedrenderFavorites()to toggle the empty state visibility and resolved a copy-pasteReferenceError(recentlyViewedSection is not defined).### Screenshots
Before
Closes #508