fix(0.6.1): dashboard p95 fallback hint -> compact tooltip#98
Open
nicolotognoni wants to merge 1 commit into
Open
fix(0.6.1): dashboard p95 fallback hint -> compact tooltip#98nicolotognoni wants to merge 1 commit into
nicolotognoni wants to merge 1 commit into
Conversation
The p95->p50 sample-threshold fallback (PR #96) renders correctly but clutters every short-call latency card with a verbose explanation row ("6 turns — p95 hidden until >=10, showing p50") plus parenthetical labels like "END-TO-END P50 (N<10)". Two lines of reasoning per panel drown out the actual numbers on every call with n<10. Replaced with a single inline "?" badge next to the affected label, whose `title`/`aria-label` carries the same explanation on hover/focus: "p95 hidden — needs >=10 turns (n=X). Currently showing p50." - LatencyPanel: removed the inline hint row; right box label drops the "(n<10)" suffix and gains a "?" badge with tooltip when n<10. - MetricsPanel (realtime + pipeline branches): same treatment as LatencyPanel. - CallTable: tooltip phrasing aligned with the panels (same string shape, no behaviour change beyond wording). - dashboard.css: new `.info-q` style — 12px circle with `?` glyph, cursor: help, dark-theme friendly via `currentColor`. Bundle re-synced via `dashboard-app/scripts/sync.mjs` so the HTML served by both SDKs reflects the new UI. No version bump (UI-only polish on top of an already-shipped 0.6.1 dashboard fix).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"X turns — p95 hidden until ≥10, showing p50"row under every latency card (and the"(N<10)"parenthetical labels) with a single inline?badge whosetitle/aria-labelshows the same explanation on hover/focus."p50 round-trip"/"end-to-end p50"/"p50"/"p50 wait"when n<10 — no more"P95 ... (N<10)"masquerade.fix/0.6.1-dashboard-p95-sample-threshold). Pure UI polish — no version bump, no behavioural change to the threshold or the underlying fallback math.Implementation
dashboard-app/src/components/LatencyPanel.tsx: dropped the inline hint row, dropped the(n<${MIN_TURNS_FOR_PERCENTILES})suffix from labels, added a<span class="info-q">?next to the affected label when!showPercentiles. Sametitle=text on the badge.dashboard-app/src/components/MetricsPanel.tsx: same treatment in both the realtime (LatencyViewrealtime branch) and pipeline branches.dashboard-app/src/components/CallTable.tsx: tooltip wording aligned with the panels ("p95 hidden — needs ≥10 turns (n=X). Currently showing p50."). The inline(p50)suffix in the cell stays — it disambiguates the value at a glance without a hover.dashboard-app/src/styles/dashboard.css: new.info-qstyle — 12px circle,?glyph,cursor: help, theme-friendly viacurrentColor.dashboard-app/scripts/sync.mjssolibraries/python/getpatter/dashboard/ui.htmlandlibraries/typescript/src/dashboard/ui.htmlreflect the UI.Before:
After:
Breaking change?
No. UI text only; no API surface, no config, no metrics math change.
Test plan
cd dashboard-app && npm test -- --run→ 16/16 pass (mergeCalls + App)cd dashboard-app && npm run lint→ tsc cleancd dashboard-app && npm run build→ tsc clean, vite bundle 208.61 kB / gzip 64.92 kBnode dashboard-app/scripts/sync.mjs→ TS & Python SDKui.htmlupdated?badge appears, hover shows tooltip, badge disappears at the 10-turn threshold.Docs updates
N/A — internal dashboard UI polish, no docs page reference this string.