Draft
Conversation
…putMixin" This reverts commit 176cb04.
Eliminate RemoveTaskOutputOnFailureMixin.
Move schedulers in a new module and add an interface for schedulable tasks. Include Luigi metadata in the Slurm --comment field.
Task parameters can be overwritten by the subclass, so it's best to defer their validation when they are actually used.
Make srun binary configurable Add individual configuration sections for each scheduler. Add a test configuration to use for the CI.
Simply use the task ID in the comment instead of nesting a JSON payload. Cache squeue output to minimize the number of calls to squeue, especially when multiple workers are overseeing Slurm jobs. Peform more validation with graceful logging when the squeue payload does not match expectations.
Use a patched LocalTarget for every tasks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.