-
Notifications
You must be signed in to change notification settings - Fork 3
fix: improved account page layout #1088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughReorganizes Account and Organization layouts: removes fixed max-widths, introduces a responsive two-column Account layout, adjusts heading levels (h3 → h4), and restructures the ProDisplay table (new headers, spacer row, re-positioned rows, and Infinity → "Unlimited" display). Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
components/Account/ProDisplay.tsx(2 hunks)components/Account/account.module.css(1 hunks)components/Organization/ViewOrganization.tsx(1 hunks)components/Organization/organization.module.css(0 hunks)pages/account/account.module.css(1 hunks)pages/account/index.tsx(2 hunks)
💤 Files with no reviewable changes (1)
- components/Organization/organization.module.css
🧰 Additional context used
🧬 Code graph analysis (1)
pages/account/index.tsx (1)
components/Organization/index.tsx (1)
ViewOrganization(10-10)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Run Tests
🔇 Additional comments (8)
components/Account/account.module.css (1)
77-80: LGTM!The new section header styling is clean and appropriate for the layout updates.
pages/account/index.tsx (1)
195-201: LGTM! Div structure is correctly nested.The closing divs properly support the two-column layout. The right column appropriately contains the ProDisplay and ViewOrganization components.
pages/account/account.module.css (2)
7-28: LGTM! Solid responsive two-column implementation.The mobile-first responsive layout is well-structured:
- Stacks vertically on mobile with 20px gap
- Switches to equal-width columns at 1200px
min-width: 0prevents flex overflow issuesalign-items: flex-startensures proper alignment
25-33: LGTM! Clean column and header styling.The
.account_columnand.section_headerstyles are appropriate and well-defined.components/Account/ProDisplay.tsx (4)
11-13: LGTM! Improved handling of infinite limits.The updated logic correctly handles both string
'Inf'and numericInfinityrepresentations.
38-38: LGTM! Consistent heading level with other sections.The h4 heading with
section_headerclass aligns with the "General" and "Organization" sections, maintaining visual consistency across the account page.
65-69: LGTM! Logical table row ordering.The "Addresses Per Button" row is positioned appropriately after the messaging-related limits.
46-52: Good accessibility improvement with descriptive table header.Adding "Account Limits" as the first column header improves table semantics and accessibility. The
header-spacerrow provides visual spacing and the class is properly defined in global styles.
lissavxo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the Organization section title font to match the other titles; the Organization title is thinner
Description
Made the /account page layout much nicer
Test plan
Go to /account and checkout the new layer. Contrast it with prod if you want.
Summary by CodeRabbit
New Features
Style
✏️ Tip: You can customize this high-level summary in your review settings.