fix(desktop): isolate packaged sidecar resolution - #12
Conversation
Signed-off-by: Schrödinger’s Cat <62413+cmyk@users.noreply.github.com>
reinhold-ph
left a comment
There was a problem hiding this comment.
APPROVE — no blocking findings in 898d562b01dda584ba42f6d6fb50c0ff7638f469...11c8fc17eb6b852546f4701f614568f10930d2db.
Independent review traced the complete packaged/development resolver control flow and all changed tests. Packaged execution is derived from the running .app, checks all configured Tauri sidecars before managed/PATH/cache fallbacks, resolves only the bundled executable, and fails closed when it is absent. Development fallback remains available outside an app bundle. DCO and git diff --check pass; no workflow, manifest, or lockfile changes are present.
The reviewer did not rerun Rust builds on the constrained Reinhold host. Executor evidence reports the full Desktop library suite (2,392 passed), file-size ratchet, and Clippy gate. Owner acceptance on the combined exact stack additionally proved that the live process selected Contents/MacOS/buzz-acp while both external debug and release binaries remained present, and that the bundled sidecar completed one first-attempt signed send with no DNS failure, elevated retry, or Guardian Review.
Summary
.app/Contents/MacOStarget/debugortarget/releaseWhy
The PR #11 staged app launched its
buzz-desktopfrom the bundle but resolvedbuzz-acpfrom an existing source worktree. A packaged build must not infer development mode from ambient checkout paths on the build machine.Verification
bundle.externalBingit diff --check: passedmainunused re-exportsjust cireaches the pre-existing Desktop Clippy failure for unusedcodex_versionre-exports indiscovery.rs; those lines are unchanged frommainand are outside this narrow resolver fix.