fix(data.atmosphere): use .data$sitename in download_NOAA_GEFS_EFI filter

[anshul23102]

Bug

download_NOAA_GEFS_EFI filters the downloaded met tibble to the requested NEON site with:

dplyr::filter(.data$reference_datetime == ..., sitename == sitename)

sitename == sitename compares the function argument to itself, which is always TRUE. The site filter has no effect, so the function returns met data for every NEON site merged together instead of only the requested one. Any model run using this function receives mixed multi-site meteorology.

Fix

# Before
dplyr::filter(.data$reference_datetime == as.POSIXct(start_date, tz = "UTC"), sitename == sitename)

# After
dplyr::filter(.data$reference_datetime == as.POSIXct(start_date, tz = "UTC"), .data$sitename == sitename)

Adding the .data$ prefix makes dplyr compare the sitename column against the sitename argument, as intended.