fix(clickhouse): preserve legacy soft-delete column casing - #4597
Open
floze-the-genius wants to merge 1 commit into
Open
fix(clickhouse): preserve legacy soft-delete column casing#4597floze-the-genius wants to merge 1 commit into
floze-the-genius wants to merge 1 commit into
Conversation
floze-the-genius
requested a deployment
to
external-contributor
July 19, 2026 02:07 — with
GitHub Actions
Waiting
floze-the-genius
requested a deployment
to
external-contributor
July 19, 2026 02:07 — with
GitHub Actions
Waiting
floze-the-genius
requested a deployment
to
external-contributor
July 19, 2026 02:07 — with
GitHub Actions
Waiting
floze-the-genius
requested a deployment
to
external-contributor
July 19, 2026 02:07 — with
GitHub Actions
Waiting
pfcoperez
reviewed
Jul 28, 2026
pfcoperez
left a comment
Member
There was a problem hiding this comment.
Thanks for your contribution! I've dropped a comment about the implementation detail.
floze-the-genius
force-pushed
the
fix/clickhouse-soft-delete-case-upgrade
branch
from
July 29, 2026 08:57
1bacbfc to
ac5fe77
Compare
floze-the-genius
requested a deployment
to
external-contributor
July 29, 2026 08:57 — with
GitHub Actions
Waiting
floze-the-genius
requested a deployment
to
external-contributor
July 29, 2026 08:57 — with
GitHub Actions
Waiting
Author
|
Narrowed the compatibility behavior in
Added positive tests for both legacy directions and negative tests for mixed/default and custom-case variants. Targeted ClickHouse tests and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Older PeerDB releases stored the UI default
_PEERDB_IS_DELETEDin mirror config, but ClickHouse table creation and normalization hardcoded the physical column as_peerdb_is_deleted. After #4365 began honoring the stored config, upgraded legacy mirrors generated inserts for the uppercase identifier even though their existing tables only had the lowercase column.Tests
go test ./connectors/clickhouse -skip '^TestCreateRawTableHasTTL$' -count=1go vet ./connectors/clickhousego test -race ./connectors/clickhouse -run 'Test(ResolveSoftDeleteColumnName|BuildQuery_UsesDestinationSoftDeleteColumnCase|ProcessTableComparison_WithResolvedSoftDeleteColumnCase)$' -count=1Fixes #4596