Lock file maintenance - #4598
Conversation
There was a problem hiding this comment.
Lock File Maintenance Review
MSRV / Build Breakage (High Severity)
The AWS SDK crate bumps in nexus/Cargo.lock raise the minimum supported Rust version (MSRV) to rustc 1.94.1, but the Docker build environment currently uses rustc 1.93.0. This causes the docker-build CI job to fail with:
error: rustc 1.93.0 is not supported by the following packages:
aws-config@1.9.0 requires rustc 1.94.1
aws-credential-types@1.3.0 requires rustc 1.94.1
aws-runtime@1.8.1 requires rustc 1.94.1
aws-sdk-kms@1.112.0 requires rustc 1.94.1
aws-sdk-sso@1.103.0 requires rustc 1.94.1
aws-sdk-ssooidc@1.105.0 requires rustc 1.94.1
aws-sdk-sts@1.108.0 requires rustc 1.94.1
aws-sigv4@1.5.1 requires rustc 1.94.1
aws-smithy-async@1.3.0 requires rustc 1.94.1
aws-smithy-http@0.64.0 requires rustc 1.94.1
aws-smithy-http-client@1.2.0 requires rustc 1.94.1
aws-smithy-json@0.63.0 requires rustc 1.94.1
aws-smithy-observability@0.3.0 requires rustc 1.94.1
aws-smithy-query@0.61.1 requires rustc 1.94.1
aws-smithy-runtime@1.12.0 requires rustc 1.94.1
aws-smithy-runtime-api@1.13.0 requires rustc 1.94.1
aws-smithy-runtime-api-macros@1.1.0 requires rustc 1.94.1
aws-smithy-schema@0.2.0 requires rustc 1.94.1
aws-smithy-types@1.6.1 requires rustc 1.94.1
aws-smithy-xml@0.61.1 requires rustc 1.94.1
aws-types@1.4.0 requires rustc 1.94.1
This PR cannot be merged as-is. Either the Rust toolchain in the Docker image needs to be updated to ≥1.94.1, or the AWS SDK crate versions need to be pinned/constrained to versions compatible with rustc 1.93.0.
Clippy Failure (Pre-existing)
The clippy CI job also fails with clippy::useless_borrows_in_formatting at peer-cursor/src/util.rs:51. This appears to be a pre-existing issue (not introduced by this PR's lock file changes), likely triggered by a newer clippy version in CI.
Cargo.lock Bumps Summary
~45 crates bumped, mostly patch versions. Notable minor bumps:
- AWS SDK suite: 21 crates bumped (see MSRV issue above)
- regex: 1.12.4 → 1.13.1 — new minor, routine feature additions
- tokio: 1.52.3 → 1.52.4 — patch fix
- rustls: 0.23.41 → 0.23.42 — patch fix
- uuid: 1.23.4 → 1.24.0 — minor bump
- http-body: 1.0.1 → 1.1.0 — minor bump
- Other crates: patch-level bumps with no known regressions
package-lock.json Bumps Summary
~50+ npm packages refreshed, all patch or minor bumps:
- next: 16.2.9 → 16.2.10 (patch)
- tailwindcss: 4.3.1 → 4.3.2 (patch)
- webpack: 5.108.1 → 5.108.4 (patch)
- typescript-eslint: 8.62.0 → 8.63.0 (minor)
- prettier: 3.9.1 → 3.9.5 (patch)
- protobufjs: 8.6.5 → 8.7.0 (minor)
- @radix-ui packages: various patch bumps
- No breaking changes or known regressions identified in npm bumps
PII/Secrets Check
No PII or secrets found in the changes. ✓
🤖 Generated with Claude Code
🔄 Flaky Test DetectedAnalysis: The single failed shard (mysql-pos 7.0) failed in MySQL test-setup with a transient handshake connection error ("readInitialHandshake ... EOF: connection was bad") on a lock-file-only Renovate PR while the other two matrix shards passed, indicating an infrastructure flake rather than a real bug. ✅ Automatically retrying the workflow |
9ea5b38 to
c0603fe
Compare
There was a problem hiding this comment.
Lock File Maintenance Review
MSRV Regression (Breaking)
The AWS SDK crate bumps in this lock file refresh require Rust 1.94.1, but the Docker build image in stacks/peerdb-server.Dockerfile pins Rust 1.93.0. This causes the docker-build CI job to fail:
error: rustc 1.93.0 is not supported by the following packages:
aws-config@1.9.0 requires rustc 1.94.1
aws-credential-types@1.3.0 requires rustc 1.94.1
aws-runtime@1.8.1 requires rustc 1.94.1
aws-sdk-kms@1.112.0 requires rustc 1.94.1
... (20 total aws-* crates)
Action required: Either bump the Rust toolchain in stacks/peerdb-server.Dockerfile to >= 1.94.1, or pin the AWS SDK crates to their previous versions in Cargo.toml.
Other Dependency Bumps — No Regressions Found
| Category | Key bumps | Verdict |
|---|---|---|
| syn 3.0.2 (new major) | Used by serde_derive, thiserror-impl, async-trait. Breaking changes are internal to syn's API; downstream proc-macro crates already absorb them. PeerDB doesn't use syn directly. | Safe |
| tokio 1.52.3 → 1.53.0 | Bug fixes (FastRand, mpsc wake timing, timer reset). No breaking changes. | Safe |
| hyper 1.10.1 → 1.11.0 | HTTP/1 correctness fixes. Additive only. | Safe |
| http-body 1.0.1 → 1.1.0 | Adds Add/Copy for SizeHint. No breaking changes. |
Safe |
| AWS SDK family | Minor bumps across ~20 crates. No API breaks beyond MSRV. | Safe (after MSRV fix) |
| rustls 0.23.41 → 0.23.42 | Patch. | Safe |
| regex 1.12.4 → 1.13.1 | Minor. | Safe |
| serde 1.0.228 → 1.0.229 | Patch. | Safe |
| Next.js 16.2.9 → 16.2.10 | Patch. | Safe |
| Radix UI (30+ packages) | Patch/minor. | Safe |
| Tailwind CSS 4.3.1 → 4.3.2 | Patch. | Safe |
Security / PII Check
No passwords, tokens, or secrets found in the diff. Lock files only.
Note on clippy CI failure
The clippy job fails on a pre-existing lint (clippy::useless_borrows_in_formatting at peer-cursor/src/util.rs:51) unrelated to this PR's lock file changes.
❌ 8 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
❌ Test FailureAnalysis: Not flaky — Test_MySQL_DateTime_ClickHouse_Range fails deterministically in all 4 ClickHouse variants because the |
c0603fe to
870df7c
Compare
Lock File Maintenance ReviewReviewed the lock file refresh across Cargo.lock highlights
package-lock.json highlights
Checks
Looks clean. 🤖 Reviewed with Claude Code |
This PR contains the following updates:
🔧 This Pull Request updates lock files to use the latest dependency versions.
Configuration
📅 Schedule: (in timezone Etc/UTC)
* 0-3 * * 1)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.