PG-PG: Add feature to clean up older raw table data, behind FF - #4624
Open
Amogh-Bharadwaj wants to merge 9 commits into
Open
PG-PG: Add feature to clean up older raw table data, behind FF#4624Amogh-Bharadwaj wants to merge 9 commits into
Amogh-Bharadwaj wants to merge 9 commits into
Conversation
serprex
approved these changes
Jul 27, 2026
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Contributor
❌ Test FailureAnalysis: The new Test_Raw_Batch_Cleanup_PG fails deterministically and identically (expected 6 rows, got 10) across all three matrix legs, meaning the PR's raw-table cleanup feature isn't pruning old batches — a real bug, not flakiness. |
Amogh-Bharadwaj
force-pushed
the
pg-pg-raw-table-cleanup
branch
from
July 28, 2026 08:29
44dbd64 to
0bcfad5
Compare
Contributor
❌ Test FailureAnalysis: The newly-added Test_Raw_Batch_Cleanup_PG (introduced by this PR, absent on main) times out with the raw-table row count frozen at 10 for the entire 60s wait on two of three matrix jobs, indicating the PR's raw-batch cleanup never runs rather than an environmental or timing flake. |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Contributor
❌ Test FailureAnalysis: Test_Raw_Batch_Cleanup_PG fails deterministically across all three matrix jobs with the raw table row count frozen at 10 until timeout, indicating the raw-table-cleanup feature this PR adds does not work; the accompanying BigQuery 503 and pg_dump "signal: killed" failures are isolated flakes that only affect single legs. |
Contributor
❌ Test FailureAnalysis: The new test Test_Raw_Batch_Cleanup_PG added by PR #4624 fails deterministically on all three PG matrix jobs with the raw table row count stuck at 10 for the full ~72s poll window, indicating the PR's raw-table cleanup logic never runs rather than any timing, race, or network flakiness. |
ilidemi
approved these changes
Jul 29, 2026
Contributor
❌ Test FailureAnalysis: Real bug: the PR's own new test Test_Raw_Batch_Cleanup_PG fails identically on all three matrix jobs (pg16/pg17/pg18) because raw-table cleanup never runs — the row count stays pinned at 10 until the 60s wait times out. |
Contributor
❌ Test FailureAnalysis: The PR's own new test Test_Raw_Batch_Cleanup_PG fails deterministically on all three Postgres matrix jobs with the raw table row count frozen at 10 until the WaitFor deadline, indicating the raw-table cleanup added by this PR never runs rather than an intermittent timing issue. |
Contributor
❌ Test FailureAnalysis: The PR's own new test Test_Raw_Batch_Cleanup_PG fails deterministically on both matrix legs, timing out after 60s with the raw table row count frozen at exactly 10 and never decreasing, indicating the PG→PG raw-table cleanup feature the PR implements is not deleting normalized batches at all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The PeerDB raw table grows large over time and has been seen to take up a lot of storage in the target Postgres peer. We want to provide an inbuilt feature to users to ensure raw table stays at a small size
This is going to be behind a feature flag default OFF for now so that upon rollout, the first occurrence of cleanup will not stall normalize due to large amount of raw table batches.
What