fix: Add error detail for validation errors in ValidatePeer - #4642
Open
itsbilal wants to merge 1 commit into
Open
fix: Add error detail for validation errors in ValidatePeer#4642itsbilal wants to merge 1 commit into
itsbilal wants to merge 1 commit into
Conversation
Previously, the FailedPreconditionApiError in ValidatePeer() had no error details, making it harder to be able to tease this error apart from the caller. This change adds a new error detail, ErrorInfoReasonSourceValidationFailed, that allows callers to be able to distinguish validation failures from calls to this method.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
ilidemi
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the FailedPreconditionApiError in ValidatePeer() had no error details, making it harder to be able to tease this error apart from the caller. This change adds a new error detail,
ErrorInfoReasonSourceValidationFailed, that allows callers to be able to distinguish validation failures from calls to this method.