-
Notifications
You must be signed in to change notification settings - Fork 213
Update github-actions dependencies #4684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rust-cache v2.9.1 -> v2.9.2 silently changes the cache-key digest — expect one cold build here.
Not a defect in this PR, and not blocking, but it isn't in the upstream changelog so it would otherwise surface as an unexplained CI slowdown: the
nexuscache is invalidated once by this bump, so the first post-merge run ofcargo check/cargo testis cold on all fivepostgres-versionmatrix legs, then re-warms.Why —
src/config.tsin the bumped range changedgetRustVersionsfrom a Set ofRustVersionobjects to a Set of strings:parseRustVersionreturned a fresh object per call, so the Set never deduped, andrustVersions.sort()over objects was a no-op (every element stringifies to[object Object])."<release> <host> <commit-hash>"strings, so they genuinely dedupe and sort.This workspace has no
rust-toolchain.tomlandci.ymlinstalls no toolchain, so Rust comes from the preinstalled rustup onubuntu-latest. There,rustc -vVandrustup run stable-x86_64-unknown-linux-gnu rustc -vVyield the same version string: v2.9.1 fed it to the sha1 hasher twice, v2.9.2 feeds it once, so the digest differs.add-rust-environment-hash-keydefaults totrue, and that digest is appended tokeybeforeself.restoreKey = key, so the restore-key prefix changes too and even the prefix-based partial restore misses.Two more items from the same range, both inert for this repo but worth recording:
buildjetcache provider removed.getCacheProvider()dropped thebuildjetcase, socache-provider: buildjetnow throws. This step uses the defaultgithub, so no impact.credentials.tomlcleanup now actually fires. The pre-save unlink path was wrong (CARGO_HOME/.cargo/credentials.toml) and is fixed toCARGO_HOME/credentials.toml. Prior versions therefore never scrubbed it, meaning a cargo registry token in~/.cargo/credentials.tomlcould be baked into the saved Actions cache. This job sets no registry token, so nothing was exposed, but the fix is a genuine improvement.The cleanup rewrites in this range (
cleanTargetDirprofile detection inverted,keepPkgwidened to target names, exact-match-before-hash-strip inrmExceptfor Cargo's V2 build-dir layout,SAVE_TARGETSwidened tocdylib/dylib/rlib/staticlib) all err toward preserving more artifacts, so the failure mode is a larger cache rather than lost build output.cleanBinalso became stricter — it now deletes exactly the recorded pre-existing binaries instead of everything not attributable to acargo install, which no longer risks removing rustup shims.The other three bumps check out. All pins resolve to their commented tags (
57fc93f= actions-timeline v3.2.0,dbcb813= login-action v4 -> v4.6.0,34d8067= release-drafter v7 -> v7.7.0), none has a follow-up patch release suggesting a regression, and no new stdout/stderr/log output in any of them can reach a secret as this repo uses them. login-action: the widened Docker Hub error body (whole response stringified instead of four known keys) only runs on the Docker Hub OIDC path — all four call sites here areghcr.iowith username/password — and thescopeToConfigDirpath-traversal hardening is a security fix on an input this repo never passes. release-drafter: the new conventional-title categorization is opt-in via aconventional:key under a category'swhen, and.github/release-drafter.ymlhere declares nocategories, so drafted notes are unchanged; theno-new-contributor-templateaddition only affects the contributors placeholder and this template is just the changes placeholder. The one thing not verifiable from outside is the GraphQL pagination refactor (hand-rolled paginator replaced with Octokit's), which in principle could change which PRs land in a draft. actions-timeline: v3.2.0's "skip synthetic parallel parents" fix specifically targetsexpand-composite-actions: true, whichtilt-flow.ymlsets — so a fix, not a regression, and observability-only either way.