Open
Conversation
remove usages of FixAccents method including tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This PR is rebased from this PR so take a look at that one first if you haven't already.
This PR fixes two issues:
FixAccentsmethod was corrupting strings and making theTestAccentstests fail. I have removed the method.IsCardLegalwhen fetching the legal cards from the .txt tile. This might be what the aboveFixAccentsmethod was trying to fix before, but with the encoding it's no longer needed.The above should fix most issues with cards names with accents. One potential issue that remains is specifically accented capital E's
("É"). MTGO itself seems to not be able to parse this one so I am unsure how the string that PDBot gets from the game log actually looks. If you know please let me know and I can include a fix for this as well.