Add diablo-drops community pack#329
Merged
github-actions[bot] merged 1 commit intoJun 29, 2026
Merged
Conversation
Contributor
✅ Pack Registry ReviewPacks
Checks
Audio Quality✅ Diablo II Loot Sounds: SILVER18 audio files analyzed — Accepted with 7 warnings Warnings — pack is accepted, but please consider addressing these in a future release:
Threshold reference
Category Coverage
|
| Category | Sounds | Status |
|---|---|---|
| session.start | 2 | ✅ |
| task.acknowledge | 1 | |
| task.complete | 7 | ✅ |
| task.error | 2 | ✅ |
| input.required | 2 | ✅ |
| resource.limit | 1 |
Pack is accepted, but please consider addressing thin categories in a future release.
Warnings
- diablo-drops: core categories with only 1 sound: task.acknowledge, resource.limit
All checks passed. Auto-approving and enabling auto-merge.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the Diablo II Loot Sounds community pack — the classic Diablo II loot-filter drop sounds mapped onto the full CESP event lifecycle.
task.completecycles seven iconic drops (rune, gem, jewel, gold, amulet, ring, rare);session.start→ enter/teleport,task.error→ hostile/stun,resource.limit→ out-of-potions,session.end→ quest complete, etc.v1.0.0schema/registry-v1.schema.json($defs/pack); inserted in alpha order betweendeep-dive-banteranddjkhaled;total_packsbumped to 343.Pre-flight (ran the CI gates locally)
qualityfield omitted (CI-owned).quality-check.py): SILVER — 0 blocking issues (high-volume / trailing-silence warnings only).3ddf3cde…d18adverified against the rawopenpeon.jsonserved at the pinnedv1.0.0ref.Licensing
license: "CC-BY-NC-4.0"on the manifest; the underlying sound effects are © Blizzard Entertainment, included as an unofficial, non-commercial fan pack (same fair-use basis as other game-derived packs in the registry).