fix(codegen): forward implicit-ctor args to a native base super() reached via require()

changelog.d/10636-implicit-ctor-native-super-forward.md

@@ -0,0 +1,16 @@
+Fixed a constructor-less subclass of a native base (`AsyncResource`,
+`AsyncLocalStorage`, `EventEmitter`, `EventEmitterAsyncResource`, `LRUCache`,
+`WebSocketServer`, the genuine `node:stream` classes) losing its `super()`
+argument forwarding and native-surface install inside a CommonJS-wrapped
+module — the shape real npm packages use. `const { AsyncResource } =
+require("node:async_hooks")` is a genuine local there (the whole module body
+runs inside the CJS wrap's IIFE), which class-heritage resolution could not
+tell apart from a real user shadow of the same name, so it fell back to a
+generic dynamic-value dispatch. For a base whose runtime value is a real ES
+`class` (`AsyncResource`, `AsyncLocalStorage`), that dispatch called the value
+without `new` and threw; for an old-style-function base (`EventEmitter`, the
+stream classes) it happened to work, through a much slower indirect path
+(measured ~5.5x more instructions per construction than the direct native
+path). Class-heritage resolution now tracks a `require()`-destructured
+binding's provenance and only treats it as shadowing when it did NOT come
+from the real native module.

crates/perry-hir/src/destructuring/var_decl_sources.rs

@@ -218,6 +218,46 @@ pub(super) fn register_destructured_stream_ctors(
         return Vec::new();
     };
 
+    // #10623: record the destructuring's PROVENANCE (local binding -> the
+    // export key it was destructured from) whenever the RHS resolves to a
+    // real native/Node-builtin module — regardless of the #8342 CJS-wrapper
+    // gate immediately below. Inside a CJS-wrapped module that gate skips the
+    // FULL native-module-alias registration (member reads/calls must fall
+    // through to the wrapper's real runtime `require(...)` there), but the
+    // destructured identifier is still genuinely bound FROM that native
+    // module at runtime. Class-heritage resolution (`class_decl.rs`) needs
+    // exactly that narrower fact to avoid treating `class X extends
+    // AsyncResource {}` as user-shadowed just because the CJS wrapper makes
+    // every top-level `const` a real local — without it, `super()` (explicit
+    // or the implicit default derived ctor) fell back to a generic
+    // call-the-value dispatch that neither installs the native base's surface
+    // nor tolerates bases whose runtime value enforces real ES `class`
+    // `[[Call]]` semantics (`AsyncResource` throws "cannot be invoked without
+    // 'new'").
+    if require_resolvable_native_specifier(init).is_some() {
+        for prop in &obj_pat.props {
+            let (key, binding) = match prop {
+                ast::ObjectPatProp::Assign(assign) => {
+                    let name = assign.key.sym.to_string();
+                    (name.clone(), name)
+                }
+                ast::ObjectPatProp::KeyValue(kv) => {
+                    let key = match &kv.key {
+                        ast::PropName::Ident(i) => i.sym.to_string(),
+                        ast::PropName::Str(s) => s.value.as_str().unwrap_or("").to_string(),
+                        _ => continue,
+                    };
+                    let ast::Pat::Ident(binding) = kv.value.as_ref() else {
+                        continue;
+                    };
+                    (key, binding.id.sym.to_string())
+                }
+                ast::ObjectPatProp::Rest(_) => continue,
+            };
+            ctx.require_destructured_native_locals.insert(binding, key);
+        }
+    }
+
     // #8342: inside a CJS-wrapped module the wrap's synthetic
     // `function require(...)` shadows the bare global `require`, and its
     // built-in arm resolves `require("process")` etc. via `createRequire` at

crates/perry-hir/src/lower/context.rs

@@ -26,7 +26,7 @@ use crate::ir::*;
 /// `b/util.ts` are `a_util_ts` and `b_util_ts` — distinct salts, and
 /// cross-module capture chains stay isolated exactly as before. Same module ⇒
 /// same salt ⇒ same-module inheritance keeps sharing parent stashes.
-fn stable_module_salt(module_identity: &str) -> u64 {
+pub(crate) fn stable_module_salt(module_identity: &str) -> u64 {
     let mut h: u64 = 0xcbf29ce484222325;
     for b in module_identity.as_bytes() {
         h ^= u64::from(*b);
@@ -36,213 +36,6 @@ fn stable_module_salt(module_identity: &str) -> u64 {
 }
 
 impl LoweringContext {
-    // #854: single-arg constructor (delegates to `with_class_id_start`).
-    // Currently only exercised from the `#[cfg(test)]` lowering tests, so it
-    // reads as dead in a non-test build. Kept as the canonical entry point.
-    #[allow(dead_code)]
-    pub fn new(source_file_path: impl Into<String>) -> Self {
-        Self::with_class_id_start(source_file_path, 1)
-    }
-
-    pub fn with_class_id_start(
-        source_file_path: impl Into<String>,
-        start_class_id: ClassId,
-    ) -> Self {
-        // No module name available (the `#[cfg(test)]` lowering entry points).
-        // Salting on the path preserves the pre-#7177 behaviour for those; the
-        // production path below passes the module name.
-        let source_file_path = source_file_path.into();
-        let identity = source_file_path.clone();
-        Self::with_class_id_start_salted(source_file_path, identity, start_class_id)
-    }
-
-    /// #7177: as [`Self::with_class_id_start`], but salts the module's
-    /// `__perry_cap_*` names on `salt_identity` — the module NAME — instead of
-    /// its absolute source path, so the emitted symbols do not change with the
-    /// checkout location.
-    pub fn with_class_id_start_salted(
-        source_file_path: impl Into<String>,
-        salt_identity: impl Into<String>,
-        start_class_id: ClassId,
-    ) -> Self {
-        let source_file_path = source_file_path.into();
-        let module_identity = salt_identity.into();
-        let tagged_template_site_salt = stable_module_salt(&module_identity);
-        Self {
-            next_local_id: 0,
-            local_source_spans: HashMap::new(),
-            classic_for_lexical_bindings: HashSet::new(),
-            next_global_id: 0,
-            next_func_id: 0,
-            next_class_id: start_class_id, // Start from the provided ID to avoid collisions across modules
-            next_enum_id: 0,
-            next_interface_id: 0,
-            next_type_alias_id: 0,
-            tagged_template_site_salt,
-            next_tagged_template_site_id: 0,
-            locals: crate::lower::Locals::new(),
-            globals: Vec::new(),
-            functions: Vec::new(),
-            func_defaults: Vec::new(),
-            classes: Vec::new(),
-            class_statics: Vec::new(),
-            class_field_names: HashMap::new(),
-            class_accessor_names: HashMap::new(),
-            class_method_names: HashMap::new(),
-            class_native_extends: Vec::new(),
-            class_field_types: HashMap::new(),
-            enums: Vec::new(),
-            pending_body_enums: Vec::new(),
-            interfaces: Vec::new(),
-            type_aliases: Vec::new(),
-            native_profile_type_aliases: HashMap::new(),
-            immutable_locals: HashSet::new(),
-            interface_source_keys: std::collections::HashMap::new(),
-            interface_object_types: std::collections::HashMap::new(),
-            imported_functions: Vec::new(),
-            builtin_named_imports: Vec::new(),
-            native_modules: Vec::new(),
-            builtin_module_aliases: Vec::new(),
-            subns_path_aliases: HashMap::new(),
-            type_param_scopes: Vec::new(),
-            type_param_constraints: Vec::new(),
-            native_instances: Vec::new(),
-            param_native_hints: HashMap::new(),
-            current_strict: false,
-            ui_widget_type_aliases: HashMap::new(),
-            deferred_unknown_native_imports: HashMap::new(),
-            current_class: None,
-            current_class_scope_depth: None,
-            current_class_inner_name: None,
-            pending_class_inner_name: None,
-            class_expr_self_bindings: Vec::new(),
-            current_class_member_is_static: false,
-            private_scopes: Vec::new(),
-            object_super_home_stack: Vec::new(),
-            extern_func_types: Vec::new(),
-            source_file_path,
-            empty_site_width_hints: std::collections::HashMap::new(),
-            exportable_object_vars: HashSet::new(),
-            pending_functions: Vec::new(),
-            closure_display_names: HashMap::new(),
-            class_display_names: HashMap::new(),
-            gen_param_prologue_len: HashMap::new(),
-            assignment_inferred_name: None,
-            inferred_class_bindings: Default::default(),
-            closure_source_text: HashMap::new(),
-            class_source_text: HashMap::new(),
-            func_return_native_instances: Vec::new(),
-            pending_classes: Vec::new(),
-            func_return_types: Vec::new(),
-            resolved_types: None,
-            pre_registered_module_vars: HashSet::new(),
-            pre_registered_module_var_decls: HashSet::new(),
-            script_var_decl_names: HashSet::new(),
-            module_level_ids: HashSet::new(),
-            sloppy_implicit_globals: Vec::new(),
-            sloppy_implicit_global_ids: HashSet::new(),
-            with_sloppy_implicit_ids: std::collections::HashMap::new(),
-            pending_with_implicit_inits: Vec::new(),
-            scope_depth: 0,
-            scope_local_marks: Vec::new(),
-            scope_module_shadow_marks: Vec::new(),
-            inside_block_scope: 0,
-            for_of_force_lazy: false,
-            namespace_vars: Vec::new(),
-            current_namespace: None,
-            module_native_instances: Vec::new(),
-            local_id_native_instances: HashMap::new(),
-            uses_fetch: false,
-            uses_webassembly: false,
-            react_default_import_local: None,
-            suppress_stdlib_dispatch_guard_once: false,
-            lowering_call_callee: false,
-            unresolved_ident_as_global: false,
-            global_intrinsic_new_once: false,
-            with_env_stack: Vec::new(),
-            var_hoisted_ids: HashSet::new(),
-            tdz_forward_ids: HashSet::new(),
-            forward_lexical_names: HashSet::new(),
-            forward_lexical_saves: Vec::new(),
-            catch_param_scopes: Vec::new(),
-            annexb_block_fn_var_ids: HashMap::new(),
-            annexb_block_fn_names_all: HashSet::new(),
-            block_fn_decl_bindings: HashMap::new(),
-            lexical_forward_decls: HashMap::new(),
-            nested_forward_scope_ids: HashSet::new(),
-            functions_index: HashMap::new(),
-            classes_index: HashMap::new(),
-            imported_functions_index: HashMap::new(),
-            builtin_module_aliases_index: HashMap::new(),
-            native_instances_index: HashMap::new(),
-            module_native_instances_index: HashMap::new(),
-            func_return_native_instances_index: HashMap::new(),
-            prescan_protected_native_params: std::collections::HashMap::new(),
-            native_modules_index: HashMap::new(),
-            module_shadow_stack: Vec::new(),
-            class_statics_index: HashMap::new(),
-            weakref_locals: HashSet::new(),
-            finreg_locals: HashSet::new(),
-            weakmap_locals: HashSet::new(),
-            weakset_locals: HashSet::new(),
-            namespace_import_locals: HashSet::new(),
-            fetch_call_response_locals: HashSet::new(),
-            namespace_import_sources: std::collections::HashMap::new(),
-            generator_func_names: HashSet::new(),
-            async_generator_func_names: HashSet::new(),
-            nested_generator_forward_referenced: HashSet::new(),
-            iterator_func_for_class: std::collections::HashMap::new(),
-            proxy_locals: HashSet::new(),
-            proxy_local_ids: HashSet::new(),
-            builtin_proto_method_locals: HashMap::new(),
-            plain_object_locals: HashSet::new(),
-            proxy_revoke_locals: HashMap::new(),
-            class_expr_aliases: HashMap::new(),
-            in_constructor_class: None,
-            current_class_is_derived: false,
-            in_class_field_init: false,
-            current_class_super_ident: None,
-            mixin_funcs: HashMap::new(),
-            anon_shape_classes: HashMap::new(),
-            anon_shape_fields: HashMap::new(),
-            closed_shape_literal_locals: HashMap::new(),
-            prefer_exported_method_shape_seed: false,
-            forward_class_names: std::collections::HashSet::new(),
-            forward_class_decl_depth: std::collections::HashMap::new(),
-            class_renames: std::collections::HashMap::new(),
-            next_class_rename_id: 0,
-            module_class_decl_names: std::collections::HashSet::new(),
-            class_decl_names_any_depth: std::collections::HashSet::new(),
-            next_anon_shape_id: 0,
-            class_method_return_types: Vec::new(),
-            class_captures: Vec::new(),
-            body_class_expr_captures: Vec::new(),
-            let_class_aliases: Vec::new(),
-            global_this_aliases: HashSet::new(),
-            prototype_aliases: HashMap::new(),
-            prototype_function_aliases: HashMap::new(),
-            function_valued_locals: HashSet::new(),
-            prototype_function_locals: HashMap::new(),
-            object_static_method_aliases: HashMap::new(),
-            array_static_method_aliases: HashMap::new(),
-            is_entry_module: false,
-            platform_globals: HashSet::new(),
-            saw_global_this_expr: false,
-            reassigned_top_level_identifiers: HashSet::new(),
-            module_strict: false,
-            strict_mode_stack: Vec::new(),
-            is_external_module: false,
-            optional_require_try_depth: 0,
-            require_local_is_create_require: false,
-            import_meta_require_local: None,
-            fn_ctor_env: super::fn_ctor_env::FnCtorEnv::default(),
-            dynamic_function_subclasses: HashMap::new(),
-            expr_lower_depth: 0,
-            prelowered_member_receiver: None,
-            in_nonarrow_fn: false,
-        }
-    }
-
     pub(crate) fn fresh_tagged_template_site_id(&mut self) -> u64 {
         let local_id = self.next_tagged_template_site_id;
         self.next_tagged_template_site_id = self.next_tagged_template_site_id.wrapping_add(1);