Skip to content

fix(test): unbreak the perry-codegen lib-test build on main (-D warnings --all-targets) - #10682

Merged
proggeramlug merged 1 commit into
mainfrom
fix-main-codegen-testbuild
Sep 19, 2026
Merged

proggeramlug merged 1 commit into
mainfrom
fix-main-codegen-testbuild

Conversation

@proggeramlug

Copy link
Copy Markdown
Contributor

main at 60922041cd does not compile perry-codegen's lib-test target: two ImportedClass fixtures are missing #10484's constructor_has_synthetic_arguments field, so the required warnings gate (RUSTFLAGS="-D warnings" cargo check --workspace --all-targets) is red for every PR in the repo.

Both fixtures now set it to false, the behaviour they were written against.

How it got in: it landed with merge train 218 (#10652). That train's lint reported the warnings step failing, I diagnosed it as two unnecessary unsafe blocks in #10612's test code, fixed those, and confirmed the fix with cargo check -p perry-runtime --lib --tests — one crate. There were two independent failures behind that single gate, and verifying one was treated as clearing both. cargo check --lib cannot see cfg(test) code at all, so only the workspace --all-targets step catches this class.

Verified: RUSTFLAGS="-D warnings" cargo check --workspace --all-targets (usual cross-host UI exclusions) finishes clean, and cargo fmt --all --check passes.

@proggeramlug
proggeramlug merged commit 8df83f8 into main Sep 19, 2026
19 of 20 checks passed
@proggeramlug
proggeramlug deleted the fix-main-codegen-testbuild branch September 19, 2026 03:55
@coderabbitai

coderabbitai Bot commented Sep 19, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: d2ec62e0-776b-49f4-8ccf-1d58e16480a8

📥 Commits

Reviewing files that changed from the base of the PR and between 6092204 and 5fa9aa5.

📒 Files selected for processing (3)
  • changelog.d/10682-codegen-testbuild-missing-field.md
  • crates/perry-codegen/src/expr/instanceof_imported_rhs_tests.rs
  • crates/perry-codegen/src/lower_call/new_builtin_shadow_tests.rs
 _______________________________________________________
< Cyberdyne Systems Model GPT-101: Code Review Edition. >
 -------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant