fix(test): unbreak the perry-codegen lib-test build on main (-D warnings --all-targets) - #10682
Merged
Merged
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainat60922041cddoes not compileperry-codegen's lib-test target: twoImportedClassfixtures are missing #10484'sconstructor_has_synthetic_argumentsfield, so the requiredwarningsgate (RUSTFLAGS="-D warnings" cargo check --workspace --all-targets) is red for every PR in the repo.Both fixtures now set it to
false, the behaviour they were written against.How it got in: it landed with merge train 218 (#10652). That train's lint reported the
warningsstep failing, I diagnosed it as two unnecessaryunsafeblocks in #10612's test code, fixed those, and confirmed the fix withcargo check -p perry-runtime --lib --tests— one crate. There were two independent failures behind that single gate, and verifying one was treated as clearing both.cargo check --libcannot seecfg(test)code at all, so only the workspace--all-targetsstep catches this class.Verified:
RUSTFLAGS="-D warnings" cargo check --workspace --all-targets(usual cross-host UI exclusions) finishes clean, andcargo fmt --all --checkpasses.